You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2021/04/21 14:45:24 UTC
[GitHub] [griffin] chitralverma opened a new pull request #590: [GRIFFIN-360] Improvements to merge_pr.py
chitralverma opened a new pull request #590:
URL: https://github.com/apache/griffin/pull/590
**What changes were proposed in this pull request?**
The merge_pr.py script can be improved with many good-to-have changes like below,
- allow python 3 compatibility
- better check for Jira dependency
- Updating Jira with more details like assignee and contributor details
- upgrading dependencies
Also added a requirements.txt file for installation of script dependencies.
**Does this PR introduce any user-facing change?**
No. Committers will use this script to merge changes.
**How was this patch tested?**
In sync with the Spark merge script. used this to merge previous PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] wankunde removed a comment on pull request #590: [GRIFFIN-360] Improvements to merge_pr.py
Posted by GitBox <gi...@apache.org>.
wankunde removed a comment on pull request #590:
URL: https://github.com/apache/griffin/pull/590#issuecomment-871041023
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] guoyuepeng merged pull request #590: [GRIFFIN-360] Improvements to merge_pr.py
Posted by GitBox <gi...@apache.org>.
guoyuepeng merged pull request #590:
URL: https://github.com/apache/griffin/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] guoyuepeng commented on pull request #590: [GRIFFIN-360] Improvements to merge_pr.py
Posted by GitBox <gi...@apache.org>.
guoyuepeng commented on pull request #590:
URL: https://github.com/apache/griffin/pull/590#issuecomment-875526716
LTGM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] wankunde commented on pull request #590: [GRIFFIN-360] Improvements to merge_pr.py
Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #590:
URL: https://github.com/apache/griffin/pull/590#issuecomment-871041023
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on pull request #590: [GRIFFIN-360] Improvements to merge_pr.py
Posted by GitBox <gi...@apache.org>.
chitralverma commented on pull request #590:
URL: https://github.com/apache/griffin/pull/590#issuecomment-824120086
@guoyuepeng @wankunde can you review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org