You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pr...@apache.org on 2017/02/27 07:05:30 UTC
zeppelin git commit: [ZEPPELIN-2164] Typo in Insufficient Privileges
popup of Zeppelin
Repository: zeppelin
Updated Branches:
refs/heads/master 47a106ab9 -> 5da963e98
[ZEPPELIN-2164] Typo in Insufficient Privileges popup of Zeppelin
### What is this PR for?
When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote".
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2164](https://issues.apache.org/jira/browse/ZEPPELIN-2164)
### How should this be tested?
Refer before/after screen shot
### Screenshots (if appropriate)
Before:
<img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png">
After:
<img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png">
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
Author: Prabhjyot Singh <pr...@gmail.com>
Closes #2064 from prabhjyotsingh/ZEPPELIN-2164 and squashes the following commits:
c4c8222 [Prabhjyot Singh] ZEPPELIN-2164: Typo in Insufficient Privileges popup of Zeppelin
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/5da963e9
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/5da963e9
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/5da963e9
Branch: refs/heads/master
Commit: 5da963e9832644a81fc46730b69fca50f8b5ccc7
Parents: 47a106a
Author: Prabhjyot Singh <pr...@gmail.com>
Authored: Fri Feb 24 11:47:24 2017 +0530
Committer: Prabhjyot Singh <pr...@gmail.com>
Committed: Mon Feb 27 12:35:23 2017 +0530
----------------------------------------------------------------------
.../src/main/java/org/apache/zeppelin/socket/NotebookServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/5da963e9/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index d9cbca8..6b4c12d 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -717,7 +717,7 @@ public class NotebookServer extends WebSocketServlet
LOG.info("Cannot {}. Connection readers {}. Allowed readers {}", op, userAndRoles, allowed);
conn.send(serializeMessage(new Message(OP.AUTH_INFO).put("info",
- "Insufficient privileges to " + op + "note.\n\n" + "Allowed users or roles: " + allowed
+ "Insufficient privileges to " + op + " note.\n\n" + "Allowed users or roles: " + allowed
.toString() + "\n\n" + "But the user " + userName + " belongs to: " + userAndRoles
.toString())));
}