You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/13 22:01:27 UTC
[kudu-CR] integration tests: end-to-end master permanent failure test
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3969
to review the following change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
integration_tests: end-to-end master permanent failure test
This commit defines a workflow for handling master permanent failures, and
includes an integration test to execute it. In production, the workflow will
be run manually by an admin, or via a script.
As part of this change, I added support for optional parameters to the new
CLI tool. It was straight-forward to reuse gflags for this.
Still to come: CLI help for positional (i.e. required) parameters.
Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
---
M src/kudu/client/client-test-util.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tools/tool_main.cc
8 files changed, 211 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3969/1
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
Line 203: tablet_print_peer_uuids.name = "print_uuids";
> I think print_peer_uuids would be better
Isn't this more accurately 'replica uuids', since I think it contains all replicas, not just the remote ones?
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
integration_tests: end-to-end master permanent failure test
This commit defines a workflow for handling master permanent failures, and
includes an integration test to execute it. In production, the workflow will
be run manually by an admin, or via a script.
As part of this change, I added support for optional parameters to the new
CLI tool. It was straight-forward to reuse gflags for this.
Still to come: CLI help for positional (i.e. required) parameters.
Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Reviewed-on: http://gerrit.cloudera.org:8080/3969
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client-test-util.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tools/tool_main.cc
8 files changed, 218 insertions(+), 31 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:
Line 57: for (const auto& gflag : action.gflags) {
> Pretty neat.
Looks glorious
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2932/
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2865/
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:
Line 57: for (const auto& gflag : action.gflags) {
> what about using google::DescribeOneFlag for this? It handles nice line-wra
Pretty neat.
I did retain the majority of this code, though, to provide a nicer usage string. What do you think of this?
adar@adar-ThinkPad-T540p:~/Source/kudu/build/debug$ bin/kudu fs print_uuid --help
Usage: bin/kudu fs print_uuid [-fs_wal_dir=<dir>] [-fs_data_dirs=<dirs>]
Print the UUID of a Kudu filesystem
-fs_wal_dir (Directory with write-ahead logs. If this is not specified, the
program will not start. May be the same as fs_data_dirs) type: string
default: ""
-fs_data_dirs (Comma-separated list of directories with data blocks. If
this is not specified, fs_wal_dir will be used as the sole data block
directory.) type: string default: ""
http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
Line 203: tablet_print_peer_uuids.name = "print_uuids";
> Isn't this more accurately 'replica uuids', since I think it contains all r
Changed to "print_replica_uuids".
Line 204: tablet_print_peer_uuids.description = "Print the uuids from a tablet's Raft configuration";
> UUIDs of the peers
Done
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3969
to look at the new patch set (#2).
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
integration_tests: end-to-end master permanent failure test
This commit defines a workflow for handling master permanent failures, and
includes an integration test to execute it. In production, the workflow will
be run manually by an admin, or via a script.
As part of this change, I added support for optional parameters to the new
CLI tool. It was straight-forward to reuse gflags for this.
Still to come: CLI help for positional (i.e. required) parameters.
Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
---
M src/kudu/client/client-test-util.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tools/tool_main.cc
8 files changed, 215 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3969/2
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3969
to look at the new patch set (#3).
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
integration_tests: end-to-end master permanent failure test
This commit defines a workflow for handling master permanent failures, and
includes an integration test to execute it. In production, the workflow will
be run manually by an admin, or via a script.
As part of this change, I added support for optional parameters to the new
CLI tool. It was straight-forward to reuse gflags for this.
Still to come: CLI help for positional (i.e. required) parameters.
Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
---
M src/kudu/client/client-test-util.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tools/tool_main.cc
8 files changed, 218 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3969/3
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3969
to look at the new patch set (#4).
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
integration_tests: end-to-end master permanent failure test
This commit defines a workflow for handling master permanent failures, and
includes an integration test to execute it. In production, the workflow will
be run manually by an admin, or via a script.
As part of this change, I added support for optional parameters to the new
CLI tool. It was straight-forward to reuse gflags for this.
Still to come: CLI help for positional (i.e. required) parameters.
Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
---
M src/kudu/client/client-test-util.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tools/tool_main.cc
8 files changed, 218 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3969/4
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:
Line 57: for (const auto& gflag : action.gflags) {
what about using google::DescribeOneFlag for this? It handles nice line-wrapping, etc, and also already includes support for printing the default, etc
http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
Line 203: tablet_print_peer_uuids.name = "print_uuids";
I think print_peer_uuids would be better
Line 204: tablet_print_peer_uuids.description = "Print the uuids from a tablet's Raft configuration";
UUIDs of the peers
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2935/
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] integration tests: end-to-end master permanent failure test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: integration_tests: end-to-end master permanent failure test
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2881/
--
To view, visit http://gerrit.cloudera.org:8080/3969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No