You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2024/04/25 03:27:57 UTC
[PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
CurtHagenlocher opened a new pull request, #41376:
URL: https://github.com/apache/arrow/pull/41376
### What changes are included in this PR?
Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0.
### Are these changes tested?
Yes
### Are there any user-facing changes?
Users will need to install .NET 8 to run tests and examples. No impact on product code.
Closes #41375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079162953
I've opened https://github.com/apache/arrow/issues/41390 to follow the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079785458
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2710626b234d5e387a3c63988ca5899c70547dcf.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/24309514782) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079050725
Revision: 14391158ae0f406724beabb94281ec1f897d65d2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a0ad3baf29](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a0ad3baf29)
|Task|Status|
|----|------|
|nuget|[](https://github.com/ursacomputing/crossbow/actions/runs/8846498195/job/24292513500)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #41376:
URL: https://github.com/apache/arrow/pull/41376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079126071
Change looks good to me. There is a single error on CI around the .NET jobs but I think is unrelated:
https://github.com/apache/arrow/actions/runs/8836761043/job/24264073837?pr=41376
```
Run ci/scripts/csharp_test.sh $(pwd)
+ source_dir=/Users/runner/work/arrow/arrow/csharp
+ '[' -z '' ']'
+ type python3
+ export PYTHON=python3
+ PYTHON=python3
+ python3 -m pip install pyarrow find-libpython
error: externally-managed-environment
× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
xyz, where xyz is the package you are trying to
install.
If you wish to install a Python library that isn't in Homebrew,
use a virtual environment:
python3 -m venv path/to/venv
source path/to/venv/bin/activate
python3 -m pip install xyz
If you wish to install a Python application that isn't in Homebrew,
it may be easiest to use 'pipx install xyz', which will manage a
virtual environment for you. You can install pipx with
brew install pipx
You may restore the old behavior of pip by passing
the '--break-system-packages' flag to pip, or by adding
'break-system-packages = true' to your pip.conf file. The latter
will permanently disable this error.
If you disable this error, we STRONGLY recommend that you additionally
pass the '--user' flag to pip, or set 'user = true' in your pip.conf
file. Failure to do this can result in a broken Homebrew installation.
Read more about this behavior here: <https://peps.python.org/pep-0668/>
note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.
```
@kou @assignUser is this something you've seen somewhere else?
I am happy to merge this PR as it seems related to the macOS changes for GitHub runners.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079047555
@github-actions crossbow submit *csharp*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079304167
Yeah, this is a recent change in the brew python. As kou said using venv solves it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079051104
Revision: 14391158ae0f406724beabb94281ec1f897d65d2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4f3461e690](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4f3461e690)
|Task|Status|
|----|------|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8846500195/job/24292519598)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8846500181/job/24292519556)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8846499882/job/24292518508)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8846500044/job/24292518989)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8846500053/job/24292519040)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8846499878/job/24292518486)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079047194
@github-actions crossbow submit nuget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2079152758
We need to use venv as the message said or actions/setup-python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41375: [C#] Move to .NET 8.0 [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #41376:
URL: https://github.com/apache/arrow/pull/41376#issuecomment-2077326420
I *think* all the failing checks are due to the recent macos-latest change, but am not confident that it's the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org