[jira] [Commented] (SAMZA-1347) GroupByContainerIds NPE if containerIds list is null

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063914#comment-16063914 ] 

ASF GitHub Bot commented on SAMZA-1347:
---------------------------------------

GitHub user jmakes opened a pull request:

    https://github.com/apache/samza/pull/233

    SAMZA-1347: GroupByContainerIds NPE if containerIds list is null

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jmakes/samza samza-1347

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #233
    
----
commit a25dcf57be0c67507236fb7be8718af6cbe22526
Author: Jacob Maes <jm...@linkedin.com>
Date:   2017-06-26T22:39:15Z

    SAMZA-1347: GroupByContainerIds NPE if containerIds list is null

----


> GroupByContainerIds NPE if containerIds list is null
> ----------------------------------------------------
>
>                 Key: SAMZA-1347
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1347
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Jake Maes
>            Assignee: Jake Maes
>
> Another low-hanging fruit. The null check in group() happens AFTER checking the size of containerIds. These statements should be reordered. 
> Also, Since the group(tasks) method always calls the group(tasks, containerIds) method, lets just move all the safety checks there.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)