[jira] [Commented] (MESOS-3052) optimize slave ID comparison in filter lists

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720786#comment-14720786 ] 

James Peach commented on MESOS-3052:
------------------------------------

[~bmahler] can you cast an eye over https://reviews.apache.org/r/37913/ ?

> optimize slave ID comparison in filter lists
> --------------------------------------------
>
>                 Key: MESOS-3052
>                 URL: https://issues.apache.org/jira/browse/MESOS-3052
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation
>            Reporter: James Peach
>            Assignee: James Peach
>         Attachments: MESOS-3052.tiff
>
>
> With a large number of frameworks that all refuse offers permanently, the filter lists can get long. Comparing the slave IDs on the long filter lists ends up taking noticeable time.
> Since each filter list traversal matches on on a single slave ID, we can optimize this by hashing the slave ID and checking the hash before comparing the full slave ID. This is a 5% - 10% performance win.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)