You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/07 19:38:00 UTC

[jira] [Work logged] (KNOX-2104) Admin UI should display the same page after successful resource operation

     [ https://issues.apache.org/jira/browse/KNOX-2104?focusedWorklogId=340108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340108 ]

ASF GitHub Bot logged work on KNOX-2104:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/19 19:37
            Start Date: 07/Nov/19 19:37
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on pull request #179: KNOX-2104 - Removing redundant resource cleanup so that data table can keep track of its activePage/rowsOnTable attributes
URL: https://github.com/apache/knox/pull/179
 
 
   ## What changes were proposed in this pull request?
   
   Staying on the same page after updating/removing a Knox resource (note: currently only `Service Definitions` is displayed with pagination since the number of other resources is less than 10).
   
   (another note: having this one line change is a result of several hours of coding and analyzing `DataTable` and trying to understand why did `activePage` always got reset even if I told the exact number. That one line caused the headache :) )
   
   ## How was this patch tested?
   
   See [this video](https://streamable.com/so8wi) about my manual testing.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 340108)
    Remaining Estimate: 0h
            Time Spent: 10m

> Admin UI should display the same page after successful resource operation
> -------------------------------------------------------------------------
>
>                 Key: KNOX-2104
>                 URL: https://issues.apache.org/jira/browse/KNOX-2104
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: AdminUI
>    Affects Versions: 1.4.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Minor
>             Fix For: 1.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As part of KNOX-2056, there was a need to introduce {{angular2-datatable}} in order to display Knox resources (topologies, service definitions, etc..) in a paginated table if needed (>10 resources found).
> As [~lmccay] indicated in one of [his review comments|https://github.com/apache/knox/pull/173#pullrequestreview-310015043] the pagination has been reset every time a service definition got updated/removed. It'd be nice to stay on the same page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)