You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2022/10/01 17:28:00 UTC
[jira] [Commented] (CASSANDRA-17595) nodetool enablefullquerylog can NPE when directory has no files
[ https://issues.apache.org/jira/browse/CASSANDRA-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611947#comment-17611947 ]
Stefan Miklosovic commented on CASSANDRA-17595:
-----------------------------------------------
I am just wondering why this was not patched for 4.0 as well? I am fixing some stuff in CASSANDRA-17933, do you mind if I back port this? [~dcapwell] [~jonmeredith]
> nodetool enablefullquerylog can NPE when directory has no files
> ---------------------------------------------------------------
>
> Key: CASSANDRA-17595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17595
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/fql
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.1-alpha1, 4.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> fqltool_test.py::TestFQLTool::test_unclean_enable found an issue with org.apache.cassandra.utils.binlog.BinLog#deleteRecursively, it assumes listing files returns empty list rather than null and throws a NPE
> {code}
> E -- StackTrace --
> E java.lang.NullPointerException
> E at org.apache.cassandra.utils.binlog.BinLog.deleteRecursively(BinLog.java:490)
> E at org.apache.cassandra.utils.binlog.BinLog.cleanDirectory(BinLog.java:477)
> E at org.apache.cassandra.utils.binlog.BinLog$Builder.build(BinLog.java:436)
> E at org.apache.cassandra.fql.FullQueryLogger.enable(FullQueryLogger.java:106)
> E at org.apache.cassandra.service.StorageService.enableFullQueryLogger(StorageService.java:6495)
> E at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> E at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> E at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> E at java.lang.reflect.Method.invoke(Method.java:498)
> E at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> E at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> E at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> E at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> E at java.lang.reflect.Method.invoke(Method.java:498)
> E at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
> E at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
> E at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
> E at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
> E at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
> E at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
> E at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
> E at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
> E at javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
> E at javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
> E at javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
> E at javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
> E at javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org