You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:48:27 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #1783: Remove unnecessary lock in MManager

HTHou commented on a change in pull request #1783:
URL: https://github.com/apache/iotdb/pull/1783#discussion_r500055421



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -1205,25 +1039,16 @@ public String getDeviceId(PartialPath path) {
     return device;
   }
 
+  // concurrent warning: you should get parent read lock before calling this method

Review comment:
       Remove it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org