You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/07/15 09:55:48 UTC
Review Request 23480: OOZIE-1882 Bulk API with bundle Id should relax regex
check for Id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23480/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1882
https://issues.apache.org/jira/browse/OOZIE-1882
Repository: oozie-git
Description
-------
Bulk API with bundle Id should relax regex check for Id
Diffs
-----
core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 8327aee
core/src/main/java/org/apache/oozie/service/UUIDService.java 7489a53
core/src/main/java/org/apache/oozie/service/ZKUUIDService.java 33d782b
core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java c41383c
core/src/test/java/org/apache/oozie/test/XDataTestCase.java a19b877
Diff: https://reviews.apache.org/r/23480/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 23480: OOZIE-1882 Bulk API with bundle Id should relax
regex check for Id
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23480/#review47828
-----------------------------------------------------------
+1 after minor comments
core/src/main/java/org/apache/oozie/service/UUIDService.java
<https://reviews.apache.org/r/23480/#comment84052>
remove the capital S in reSet.
core/src/main/java/org/apache/oozie/service/ZKUUIDService.java
<https://reviews.apache.org/r/23480/#comment84054>
since getting rid of this, is this also removed from oozie-default.xml if exists? If not, ignore
core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java
<https://reviews.apache.org/r/23480/#comment84053>
formatting
- Mona Chitnis
On July 15, 2014, 7:55 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23480/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 7:55 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1882
> https://issues.apache.org/jira/browse/OOZIE-1882
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Bulk API with bundle Id should relax regex check for Id
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 8327aee
> core/src/main/java/org/apache/oozie/service/UUIDService.java 7489a53
> core/src/main/java/org/apache/oozie/service/ZKUUIDService.java 33d782b
> core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java c41383c
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java a19b877
>
> Diff: https://reviews.apache.org/r/23480/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>