You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/23 21:17:17 UTC

[GitHub] [beam] jrmccluskey commented on a change in pull request #16350: [BEAM-13534] Update TestAutomatedExpansionService liveness check to not depend on exec call

jrmccluskey commented on a change in pull request #16350:
URL: https://github.com/apache/beam/pull/16350#discussion_r774781474



##########
File path: sdks/go/test/integration/xlang/expansion_test.go
##########
@@ -65,7 +48,13 @@ func TestAutomatedExpansionService(t *testing.T) {
 		t.Errorf("failed to start expansion service JAR, got %v", err)
 	}
 
-	checkPort(t, expansionPort, 15*time.Second)
+	ctx, canFunc := context.WithTimeout(context.Background(), 15*time.Second)
+	t.Cleanup(func() { canFunc() })
+	conn, err := grpc.DialContext(ctx, "localhost:"+expansionPort, grpc.WithInsecure())

Review comment:
       FIxed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org