You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/07 02:39:14 UTC
[GitHub] [shardingsphere] isHuangXin opened a new pull request, #20843: Add convert shadow distsql and test case
isHuangXin opened a new pull request, #20843:
URL: https://github.com/apache/shardingsphere/pull/20843
For #17939
Changes proposed in this pull request:
- Add convert shadow distsql
- Add test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] isHuangXin commented on pull request #20843: Add convert shadow distsql and test case
Posted by GitBox <gi...@apache.org>.
isHuangXin commented on PR #20843:
URL: https://github.com/apache/shardingsphere/pull/20843#issuecomment-1240093603
This is so weird, I have adjusted the order of the parameters in the shadow tables properties.
The picture is the result of the printout of my code.
<img width="1511" alt="Screen Shot 2022-09-08 at 09 04 10" src="https://user-images.githubusercontent.com/57054352/189011010-95d0b5ca-9c65-4432-a90a-682691dad954.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #20843: Add convert shadow distsql and test case
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #20843:
URL: https://github.com/apache/shardingsphere/pull/20843#issuecomment-1240128609
> About CI error, this is so weird. I have adjusted the order of the parameters in the shadow tables properties. The picture is the result of the printout of my code.
>
> <img alt="Screen Shot 2022-09-08 at 09 04 10" width="1511" src="https://user-images.githubusercontent.com/57054352/189011010-95d0b5ca-9c65-4432-a90a-682691dad954.png">
>
> <img alt="Screen Shot 2022-09-08 at 09 23 05" width="1511" src="https://user-images.githubusercontent.com/57054352/189012927-8c2f70d0-cddf-4dc1-b63d-b6c55bc175c7.png">
Hi @isHuangXin
Because Properties is an inherited HashTable, keys are not guaranteed in order.
Can we compare line by line here, and then use contains to make an assertion on the Properties line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #20843: Add convert shadow distsql and test case
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #20843:
URL: https://github.com/apache/shardingsphere/pull/20843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20843: Add convert shadow distsql and test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20843:
URL: https://github.com/apache/shardingsphere/pull/20843#issuecomment-1246435658
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20843](https://codecov.io/gh/apache/shardingsphere/pull/20843?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cb018c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/46eb7310e5b5681de8b2501498aece6dbddaf580?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46eb731) will **increase** coverage by `0.04%`.
> The diff coverage is `87.09%`.
```diff
@@ Coverage Diff @@
## master #20843 +/- ##
============================================
+ Coverage 61.80% 61.84% +0.04%
Complexity 2465 2465
============================================
Files 4034 4034
Lines 55451 55542 +91
Branches 9400 9419 +19
============================================
+ Hits 34271 34350 +79
- Misses 18311 18316 +5
- Partials 2869 2876 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ral/queryable/ConvertYamlConfigurationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9Db252ZXJ0WWFtbENvbmZpZ3VyYXRpb25IYW5kbGVyLmphdmE=) | `83.67% <86.36%> (+0.58%)` | :arrow_up: |
| [...ql/ral/common/constant/DistSQLScriptConstants.java](https://codecov.io/gh/apache/shardingsphere/pull/20843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2NvbW1vbi9jb25zdGFudC9EaXN0U1FMU2NyaXB0Q29uc3RhbnRzLmphdmE=) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] isHuangXin commented on pull request #20843: Add convert shadow distsql and test case
Posted by GitBox <gi...@apache.org>.
isHuangXin commented on PR #20843:
URL: https://github.com/apache/shardingsphere/pull/20843#issuecomment-1248449841
Hi, @RaigorJiang.
Thanks for your timely code review comments. I have updated the code according to your comments on the slack channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org