[GitHub] [beam] johnjcasey commented on a diff in pull request #26100: Use external config schema to construct Python SchemaTransform payload

["johnjcasey (via GitHub)" <gi...@apache.org>]

johnjcasey commented on code in PR #26100:
URL: https://github.com/apache/beam/pull/26100#discussion_r1158868626


##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -180,14 +180,52 @@ def _get_named_tuple_instance(self):
 
 
 class SchemaTransformPayloadBuilder(PayloadBuilder):
-  def __init__(self, identifier, **kwargs):
-    self._identifier = identifier
+  def __init__(self, schematransform_config, strict_schema=False, **kwargs):
+    self._schematransform_config = schematransform_config
+    self._strict_schema = strict_schema
     self._kwargs = kwargs
 
+  def _get_schema_proto_and_payload(self, **kwargs):

Review Comment:
   do you also want to check that there are no kwargs beyond those in the schema?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org