[jira] [Comment Edited] (YETUS-506) Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010738#comment-16010738 ] 

Allen Wittenauer edited comment on YETUS-506 at 5/15/17 4:04 PM:
-----------------------------------------------------------------

It's pretty much baked into yetus that module name = directory name.  But changing the various MODULE vars to reflect directory might work.  A concern though... running:

{code}
mvn -q --also-make exec:exec -Dexec.executable=pwd
{code}

on Hadoop:

a) is extremely slow
b) fails

We probably need to tread carefully here.  That said, I'm still hopeful.  Worse case, we make it an option.


was (Author: aw):
It's pretty much baked into yetus that module name = directory name.  But changing the various MODULE vars to reflect directory might work.  A concern though... running:

{code}
mvn -q --also-make exec:exec -Dexec.executable=pwd
{code}

on Hadoop:

a) is extremely slow
b) fails

We probably need to tread carefully here.  That said, I'm still hopefully here.  Worse case, we make it an option.

> Enhance maven_reorder_module_process to handle modules where directory name is different than the artifactId
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: YETUS-506
>                 URL: https://issues.apache.org/jira/browse/YETUS-506
>             Project: Yetus
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: YETUS-506.00.patch
>
>
> The Hive source looks like this:
> {code}
> hive
> |-common
> \-ql
> {code}
> The module hierarchy is this:
> {code}
> hive
> |-hive-common
> \-hive-exec
> {code}
> As a result of this differences, the {{maven_reorder_module_process}} unable to identify these modules, and does not reorder them.
> Also the current  code expects that every artifact_id is different which might be, or might not be a problem.
> It would be much cleaner if we check the actual folder names instead which we can get by the following command:
> {code}
> mvn -q --also-make exec:exec -Dexec.executable=pwd
> {code}
> [~busbey], [~sekikn]: Do you think it would be good to include this in the Yetus head, or should I keep this change in Hive?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)