Possible error in org.apache.slide.search.basic.BasicExpressionCompiler

[ro...@mekon.com]

Hi,

I am implementing an index store with store specific expressoin
factories and have perhaps found an error in the
BasicExpressionCompiler.createExpression method.

In the constructor the property and content expression factories are
obtained an initialised, but in createExpression they are requested
again, but not initialised.

Why are they requested again?

Would it not be better to use the previously initialised members i.e.:

        if (isContentExpression (expressionElement)) {
            factory = contentExpressionFactory;
        }
        else {
            factory = propertiesExpressionFactory;
        }
   
Cheers

Rob Tomlin

---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org