You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Tak Lon (Stephen) Wu (JIRA)" <ji...@apache.org> on 2018/07/18 00:11:00 UTC
[jira] [Comment Edited] (HBASE-20401) Make `MAX_WAIT` and
`waitIfNotFinished` in CleanerContext configurable
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547239#comment-16547239 ]
Tak Lon (Stephen) Wu edited comment on HBASE-20401 at 7/18/18 12:10 AM:
------------------------------------------------------------------------
[~yuzhihong@gmail.com] thanks for reviewing this, I have attached master branch and other branches with adding {{OLD_WALS_}} those constants. NOTE that branch-1 has a minor difference in {{LOG.warn}} line.
was (Author: taklwu):
[~yuzhihong@gmail.com] thanks for reviewing this, I have attached master branch and other branches with adding OLD_WALS_** those constants
> Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable
> ----------------------------------------------------------------------
>
> Key: HBASE-20401
> URL: https://issues.apache.org/jira/browse/HBASE-20401
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 3.0.0, 1.5.0, 2.0.0-beta-1, 1.4.4, 2.0.0
> Reporter: Tak Lon (Stephen) Wu
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-20401.branch-1.001.patch, HBASE-20401.branch-1.002.patch, HBASE-20401.branch-2.001.patch, HBASE-20401.master.001.patch, HBASE-20401.master.002.patch
>
>
> When backporting HBASE-18309 in HBASE-20352, the deleteFiles calls CleanerContext.java#getResult with a waitIfNotFinished timeout to wait for notification (notify) from the fs.delete file thread. there might be two situation need to tune the MAX_WAIT in CleanerContext or waitIfNotFinished when LogClearner call getResult.
> # fs.delete never complete (strange but possible), then we need to wait for a max of 60 seconds. here, 60 seconds might be too long
> # getResult is waiting in the period of 500 milliseconds, but the fs.delete has completed and setFromClear is set but yet notify(). one might want to tune this 500 milliseconds to 200 or less .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)