You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/17 18:51:59 UTC
[jira] [Commented] (THRIFT-3886) PHP cross test client returns 0
even when failing
[ https://issues.apache.org/jira/browse/THRIFT-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674503#comment-15674503 ]
ASF GitHub Bot commented on THRIFT-3886:
----------------------------------------
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1131
THRIFT-3886 PHP cross test client returns 0 even when failing
PHP tests are mostly not asserting that the returned result is as
expected, nor do they return an error for unknown protocols.
Add more assertions in the style of the existing code, and check that the
tested protocol is supported.
This requires some fixes so tests will actually run for the accelerated
binary protocol.
Fixing the tests uncovers some brokenness in compact protocol and the extension, will submit fixes as separate patches.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhaakhi/thrift THRIFT-3886
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1131
----
commit c3e80ca473a0e4e4be9c42d98ab58826fd96a919
Author: Håkon Hitland <ha...@zedge.net>
Date: 2016-11-17T15:18:03Z
THRIFT-3886 PHP cross test client returns 0 even when failing
PHP tests are mostly not asserting that the returned result is as
expected, nor do they return an error for unknown protocols.
Add more assertions in the style of the existing code, and check that the
tested protocol is supported.
This requires some fixes so tests will actually run for the accelerated
binary protocol.
----
> PHP cross test client returns 0 even when failing
> -------------------------------------------------
>
> Key: THRIFT-3886
> URL: https://issues.apache.org/jira/browse/THRIFT-3886
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library, Test Suite
> Reporter: Aki Sukegawa
>
> PHP cross test client never fails on invalid values.
> update:
> Results for primitive values are now validated after PR #1054.
> Structs, containers, etc are still affected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)