You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/29 08:33:10 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #4891: OpenAPI: Have the type before if it is required
Fokko opened a new pull request, #4891:
URL: https://github.com/apache/iceberg/pull/4891
For Python, when we generate classes it is required
to have the non-default variables first:
This is not allowed:
```python
class ListType(IcebergType, rest_catalog.ListType):
def __init__(
cls,
element_id: int,
element_required: bool = True,
type: IcebergType
):
```
It would be nice to have the type first (which is also more important),
and then required/optional. Of course, we can just adjust this in the
Python init method, but would be nice to have this order the same in the
open-api spec as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4891: OpenAPI: Have the type before type_required
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4891:
URL: https://github.com/apache/iceberg/pull/4891#issuecomment-1140520770
Sounds reasonable to me. Thanks, @Fokko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4891: OpenAPI: Have the type before type_required
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4891:
URL: https://github.com/apache/iceberg/pull/4891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org