You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/11 02:16:35 UTC

[GitHub] [beam] udim commented on pull request #14180: [BEAM-11719] Allow encoding protos and dataclasses as deterministically.

udim commented on pull request #14180:
URL: https://github.com/apache/beam/pull/14180#issuecomment-796378482


   Some mypy failures:
   ```
   17:45:12 apache_beam/coders/coder_impl.py:73: error: Incompatible types in assignment (expression has type "None", variable has type Module)  [assignment]
   17:45:12 apache_beam/coders/coder_impl.py:503: error: Need type annotation for '_unpickled_types' (hint: "_unpickled_types: Dict[<type>, <type>] = ...")  [var-annotated]
   17:45:14 apache_beam/coders/coders_test_common.py:53: error: Incompatible types in assignment (expression has type "None", variable has type Module)  [assignment]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org