You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/14 10:11:05 UTC

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4312: support parsing multiple parameter-marker from one expr

terrymanu commented on a change in pull request #4312: support parsing multiple parameter-marker from one expr
URL: https://github.com/apache/incubator-shardingsphere/pull/4312#discussion_r379348103
 
 

 ##########
 File path: sharding-sql-test/src/main/resources/sql/supported/dml/update.xml
 ##########
 @@ -20,7 +20,7 @@
     <sql-case id="update_without_alias" value="UPDATE t_order SET status = ? WHERE order_id = ? AND user_id = ?" />
     <sql-case id="update_with_alias" value="UPDATE t_order AS o SET o.status = ? WHERE o.order_id = ? AND o.user_id = ?" db-types="MySQL,H2" />
     <!-- FIXME cannot parse multiple parameter-marker from one expr -->
 
 Review comment:
   We should remove FIXME if the case fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services