You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2011/08/18 20:02:29 UTC

[jira] [Created] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Add a eclipse-generated files to .gitignore
-------------------------------------------

                 Key: HADOOP-7555
                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
             Project: Hadoop Common
          Issue Type: Improvement
          Components: build
    Affects Versions: 0.23.0
            Reporter: Aaron T. Myers
            Assignee: Aaron T. Myers
            Priority: Trivial
             Fix For: 0.23.0
         Attachments: hadoop-7555.0.patch

The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087188#comment-13087188 ] 

Hudson commented on HADOOP-7555:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #753 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/753/])
    HADOOP-7555. Add a eclipse-generated files to .gitignore. (atm)

atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1159350
Files : 
* /hadoop/common/trunk/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce/.gitignore
* /hadoop/common/trunk/.gitignore


> Add a eclipse-generated files to .gitignore
> -------------------------------------------
>
>                 Key: HADOOP-7555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7555.0.patch
>
>
> The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7555:
-----------------------------------

    Status: Patch Available  (was: Open)

> Add a eclipse-generated files to .gitignore
> -------------------------------------------
>
>                 Key: HADOOP-7555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7555.0.patch
>
>
> The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087170#comment-13087170 ] 

Hadoop QA commented on HADOOP-7555:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12490827/hadoop-7555.0.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//console

This message is automatically generated.

> Add a eclipse-generated files to .gitignore
> -------------------------------------------
>
>                 Key: HADOOP-7555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7555.0.patch
>
>
> The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087168#comment-13087168 ] 

Todd Lipcon commented on HADOOP-7555:
-------------------------------------

+1

> Add a eclipse-generated files to .gitignore
> -------------------------------------------
>
>                 Key: HADOOP-7555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7555.0.patch
>
>
> The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7555:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Thanks a lot for the review, Todd. I've just committed this.

> Add a eclipse-generated files to .gitignore
> -------------------------------------------
>
>                 Key: HADOOP-7555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7555.0.patch
>
>
> The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7555) Add a eclipse-generated files to .gitignore

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7555:
-----------------------------------

    Attachment: hadoop-7555.0.patch

Patch which addresses the issue.

> Add a eclipse-generated files to .gitignore
> -------------------------------------------
>
>                 Key: HADOOP-7555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7555
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7555.0.patch
>
>
> The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira