You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/24 06:07:51 UTC

[GitHub] [dolphinscheduler] WangJPLeo commented on a diff in pull request #11617: [Fix-11616] Workflow Definition Name Change Validation Optimization.

WangJPLeo commented on code in PR #11617:
URL: https://github.com/apache/dolphinscheduler/pull/11617#discussion_r953384006


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java:
##########
@@ -194,11 +194,13 @@ Map<String, Object> updateProcessDefinition(User loginUser,
      * @param loginUser login user
      * @param projectCode project code
      * @param name name
+     * @param code code
      * @return true if process definition name not exists, otherwise false
      */
     Map<String, Object> verifyProcessDefinitionName(User loginUser,
                                                     long projectCode,
-                                                    String name);
+                                                    String name,
+                                                    long code);

Review Comment:
   ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org