You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/17 22:12:24 UTC
[GitHub] [hive] mustafaiman opened a new pull request #1277: HIVE-23855: TestQueryShutdownHooks is flaky
mustafaiman opened a new pull request #1277:
URL: https://github.com/apache/hive/pull/1277
Increased timeout for async query. Test were not isolated very well. Test async query did not clean up properly. State leaked to test sync causing it to fail. Cleanup is moved to @After so cleanup is always run.
Change-Id: I669ba35c22020910f5e348003b1f05d8a7cde75d
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #1277: HIVE-23855: TestQueryShutdownHooks is flaky
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #1277:
URL: https://github.com/apache/hive/pull/1277#discussion_r458061768
##########
File path: service/src/test/org/apache/hadoop/util/ShutdownHookManagerInspector.java
##########
@@ -20,9 +20,20 @@
import java.util.List;
+import static org.junit.Assert.assertEquals;
+
public class ShutdownHookManagerInspector {
- public static List<ShutdownHookManager.HookEntry> getShutdownHooksInOrder() {
- return ShutdownHookManager.get().getShutdownHooksInOrder();
+ public static int getShutdownHookCount() {
+ return ShutdownHookManager.get().getShutdownHooksInOrder().size();
+ }
+
+ public static void assertShutdownHookCount(int expected) {
+ List<ShutdownHookManager.HookEntry> entries = ShutdownHookManager.get().getShutdownHooksInOrder();
+ StringBuilder errorBuilder = new StringBuilder("Shutdown hooks:\n");
+ for (ShutdownHookManager.HookEntry entry: entries) {
Review comment:
nit: space before col
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mustafaiman closed pull request #1277: HIVE-23855: TestQueryShutdownHooks is flaky
Posted by GitBox <gi...@apache.org>.
mustafaiman closed pull request #1277:
URL: https://github.com/apache/hive/pull/1277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mustafaiman closed pull request #1277: HIVE-23855: TestQueryShutdownHooks is flaky
Posted by GitBox <gi...@apache.org>.
mustafaiman closed pull request #1277:
URL: https://github.com/apache/hive/pull/1277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org