You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mikhail Fursov (JIRA)" <ji...@apache.org> on 2006/10/03 16:55:19 UTC
[jira] Created: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
[drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
--------------------------------------------------------------------------
Key: HARMONY-1677
URL: http://issues.apache.org/jira/browse/HARMONY-1677
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Mikhail Fursov
Attachments: magic_jet1.zip
This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=comments#action_12439990 ]
weldon washburn commented on HARMONY-1677:
------------------------------------------
magic_jet1.zip will not compile on windows
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=all ]
weldon washburn closed HARMONY-1677.
------------------------------------
Resolution: Fixed
this patch allows simple MMTk configuration (mark/sweep) to run.
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip, magic_jet2.zip, magic_jet3.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=comments#action_12440319 ]
weldon washburn commented on HARMONY-1677:
------------------------------------------
It looks like Address.isZero() is broken. The following test shows a variable of type Address changes value after Address.isZero() is called:
static void testZero()
{
System.out.println("------ testZero() ---");
Address aa = Address.fromInt(0xffFFffFF);
System.out.println("aa = " + Integer.toHexString(aa.toInt() ) );
boolean zz = aa.isZero();
System.out.println("aa = " + Integer.toHexString(aa.toInt() ) + " zz = " + zz );
aa = Address.fromInt(0x0);
System.out.println("aa = " + Integer.toHexString(aa.toInt() ) );
zz = aa.isZero();
System.out.println("aa = " + Integer.toHexString(aa.toInt() ) + " zz = " + zz );
aa = Address.fromInt(0x1234);
System.out.println("aa = " + Integer.toHexString(aa.toInt() ) );
zz = aa.isZero();
System.out.println("aa = " + Integer.toHexString(aa.toInt() ) + " zz = " + zz );
}
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip, magic_jet2.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=all ]
Mikhail Fursov updated HARMONY-1677:
------------------------------------
Attachment: magic_jet2.zip
Updated:
1) Attempt op implemented and tested
2) Signed comparisons fixed.
tested on Linux & Windows ia32 builds
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip, magic_jet2.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=all ]
Mikhail Fursov updated HARMONY-1677:
------------------------------------
Attachment: magic_jet3.zip
Fixes for 'isZero' and 'toLong' ops
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip, magic_jet2.zip, magic_jet3.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=all ]
Mikhail Fursov updated HARMONY-1677:
------------------------------------
Attachment: magic_jet1.zip
The initial checkin.
1) The known problem: attempt is not implemented
2) Magic objects are reported to GC and this must be fixed.
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: magic_jet1.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=comments#action_12440206 ]
weldon washburn commented on HARMONY-1677:
------------------------------------------
Mikhail,
Thanks. I downloaded the patch and did a clean build. All the regression tests work except for 3 sign extend tests and, of course, the atomic CAS tests.
The AddressTest.toLong() might actually be working correctly. The test may not be properly constructed. In any case, I recall this test passing on the previous version of JET. The test is:
public static boolean toLong() {
Address adr = Address.fromInt(0xffFFffFF);
long lon = adr.toLong();
System.out.print(" --- lon = " + Long.toHexString(lon) + "--- ");
return lon == 0x00000000ffFFffFFL;
}
ExtentTest.fromIntSignExtend() also needs to be looked at:
public static boolean fromIntSignExtend()
{
boolean res = true; //wjw is this test correct???
//System.out.println("fromIntSignExtend " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong() ) );
System.out.print(" --- 0xBABA = " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong() ) + " --- ");
res &= Extent.fromIntSignExtend(0xBABA).toLong() == 0xffFFffFFffFFBABAL;
res &= Extent.fromIntSignExtend(0xffffffff).toLong() == 0xFFffFFffFFffFFffL;
System.out.print(" --- 0xffFFffFF = " + Long.toHexString(Extent.fromIntSignExtend(0xffFFffFF).toLong() ) + " --- ");
return res;
}
And the same for WordTest:
public static boolean fromIntSignExtend()
{
boolean res = true; //wjw is this test correct???
//System.out.println("fromIntSignExtend " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong() ) );
System.out.print("--- 0xBABA = " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong() ) + " --- " );
res &= Word.fromIntSignExtend(0xBABA).toLong() == 0xffFFffFFffFFBABAL;
System.out.print("--- 0xffFFffFF = " + Long.toHexString(Extent.fromIntSignExtend(0xffFFffFF).toLong() ) + " --- " );
res &= Word.fromIntSignExtend(0xffffffff).toLong() == 0xFFffFFffFFffFFffL;
return res;
}
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip, magic_jet2.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=all ]
weldon washburn reassigned HARMONY-1677:
----------------------------------------
Assignee: weldon washburn
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=comments#action_12440350 ]
Mikhail Fursov commented on HARMONY-1677:
-----------------------------------------
Weldon, I fixed isZero and toLong problems and going to commit the updated patch into the JIRA in a hour or two
But I think that the following lines from the second and third test are incorrect:
res &= Extent.fromIntSignExtend(0xBABA).toLong() == 0xffFFffFFffFFBABAL;
res &= Extent.fromIntSignExtend(0xffffffff).toLong() == 0xFFffFFffFFffFFffL;
Extent is 32-bit unsigned for IA32. So we ask to convert positive value to 'long' -> the result must be positive too.
?
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip, magic_jet2.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics
implementation for Jitrino.JET compiler.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1677?page=comments#action_12440050 ]
Mikhail Fursov commented on HARMONY-1677:
-----------------------------------------
I'm sorry, it looks like I saved working files extra time before making a patch, so the diff contains some unfinished 'cmpxchg' (attempt) code that brokes compilation.
Anyway, I going to commit a fresh version with more stable implementation in a several hours.
> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
> Key: HARMONY-1677
> URL: http://issues.apache.org/jira/browse/HARMONY-1677
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: weldon washburn
> Attachments: magic_jet1.zip
>
>
> This JIRA contains 'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira