You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jochen Kuhnle (JIRA)" <ji...@codehaus.org> on 2006/03/19 16:53:11 UTC
[jira] Created: (MPLUGIN-15) Support includes/excludes
Support includes/excludes
-------------------------
Key: MPLUGIN-15
URL: http://jira.codehaus.org/browse/MPLUGIN-15
Project: Maven 2.x Plugin Plugin
Type: Improvement
Reporter: Jochen Kuhnle
Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
Any suggestions?
[1] http://jira.codehaus.org/browse/MPLUGIN-1
[2] http://jira.codehaus.org/browse/QDOX-94
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] (MPLUGIN-15) Support includes/excludes
Posted by "Leon Franzen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MPLUGIN-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295229#comment-295229 ]
Leon Franzen commented on MPLUGIN-15:
-------------------------------------
We have a peculiar case where our source control system creates src directories where the source files are each symlinks into a subdirectory that should be hidden directories by virtue of the fact they start with a '.'. This causes the default configuration of the maven-plugin-plugin to find two of every source file. The QDOX parser doesn't appreciate the duplication and fails.
I've attached a patch based on trunk rev 1305952 to allow optional specification of includes and excludes patterns. It works for the script and Java extractor implementations. Default configuration should behave exactly as before. Specification of includes element will override the default behavior. Please let me know if my fix is not acceptable in any way and I'll try to make appropriate changes.
> Support includes/excludes
> -------------------------
>
> Key: MPLUGIN-15
> URL: https://jira.codehaus.org/browse/MPLUGIN-15
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API, Plugin Plugin
> Reporter: Jochen Kuhnle
> Attachments: trunk.patch
>
>
> Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
> This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
> If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
> Any suggestions?
> [1] MPLUGIN-1
> [2] QDOX-94
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MPLUGIN-15) Support includes/excludes
Posted by "Leon Franzen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MPLUGIN-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leon Franzen updated MPLUGIN-15:
--------------------------------
Attachment: trunk.patch
Maven plugin include/excludes configuration
> Support includes/excludes
> -------------------------
>
> Key: MPLUGIN-15
> URL: https://jira.codehaus.org/browse/MPLUGIN-15
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API, Plugin Plugin
> Reporter: Jochen Kuhnle
> Attachments: trunk.patch
>
>
> Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
> This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
> If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
> Any suggestions?
> [1] MPLUGIN-1
> [2] QDOX-94
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPLUGIN-15) Support includes/excludes
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MPLUGIN-15:
-------------------------------------
Component/s: Plugin Plugin
API
> Support includes/excludes
> -------------------------
>
> Key: MPLUGIN-15
> URL: http://jira.codehaus.org/browse/MPLUGIN-15
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API, Plugin Plugin
> Reporter: Jochen Kuhnle
>
> Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
> This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
> If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
> Any suggestions?
> [1] MPLUGIN-1
> [2] QDOX-94
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPLUGIN-15) Support includes/excludes
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MPLUGIN-15:
-----------------------------------
Description:
Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
Any suggestions?
[1] MPLUGIN-1
[2] QDOX-94
was:
Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
Any suggestions?
[1] http://jira.codehaus.org/browse/MPLUGIN-1
[2] http://jira.codehaus.org/browse/QDOX-94
> Support includes/excludes
> -------------------------
>
> Key: MPLUGIN-15
> URL: http://jira.codehaus.org/browse/MPLUGIN-15
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Reporter: Jochen Kuhnle
>
> Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
> This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
> If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
> Any suggestions?
> [1] MPLUGIN-1
> [2] QDOX-94
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MPLUGIN-15) Support includes/excludes
Posted by "Leon Franzen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MPLUGIN-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295229#comment-295229 ]
Leon Franzen edited comment on MPLUGIN-15 at 3/29/12 11:55 AM:
---------------------------------------------------------------
We have a peculiar case where our source control system creates src directories where the source files are each symlinks into a subdirectories that should be hidden by virtue of the fact they start with a dot ("."). Because the maven-plugin-plugin matches the symlink plus the linked-to hidden source, it causes the default configuration of the maven-plugin-plugin to attempt to parse two of every source file. The QDOX parser doesn't appreciate the duplication and fails.
I've attached a patch based on trunk rev 1305952 to allow optional specification of includes and excludes patterns. It works for the script and Java extractor implementations. Default configuration should behave exactly as before. Specification of includes element will override the default behavior. Please let me know if my fix is not acceptable in any way and I'll try to make appropriate changes.
was (Author: leon.franzen):
We have a peculiar case where our source control system creates src directories where the source files are each symlinks into a subdirectory that should be hidden directories by virtue of the fact they start with a '.'. This causes the default configuration of the maven-plugin-plugin to find two of every source file. The QDOX parser doesn't appreciate the duplication and fails.
I've attached a patch based on trunk rev 1305952 to allow optional specification of includes and excludes patterns. It works for the script and Java extractor implementations. Default configuration should behave exactly as before. Specification of includes element will override the default behavior. Please let me know if my fix is not acceptable in any way and I'll try to make appropriate changes.
> Support includes/excludes
> -------------------------
>
> Key: MPLUGIN-15
> URL: https://jira.codehaus.org/browse/MPLUGIN-15
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API, Plugin Plugin
> Reporter: Jochen Kuhnle
> Attachments: trunk.patch
>
>
> Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.
> This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).
> If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.
> Any suggestions?
> [1] MPLUGIN-1
> [2] QDOX-94
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira