You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/20 14:57:59 UTC
[GitHub] [doris] BePPPower opened a new pull request, #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
BePPPower opened a new pull request, #15216:
URL: https://github.com/apache/doris/pull/15216
# Proposed changes
Issue Number: close #xxx
This pr fix some bugs:
1. `desc function tvf(..)` throws NullPointException.
2. `Show Tables` in multi catalog did not catch some exception.
3. jdbc catalog did not handle `decimal unsigned` mysql data type.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [x] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15216:
URL: https://github.com/apache/doris/pull/15216#discussion_r1053905729
##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -338,6 +341,14 @@ public Type mysqlTypeToDoris(JdbcFieldSchema fieldSchema) {
return Type.BIGINT;
case "BIGINT":
return ScalarType.createStringType();
+ case "DECIMAL":
Review Comment:
Please add regression test for this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15216:
URL: https://github.com/apache/doris/pull/15216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BePPPower commented on a diff in pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by GitBox <gi...@apache.org>.
BePPPower commented on code in PR #15216:
URL: https://github.com/apache/doris/pull/15216#discussion_r1053948598
##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -338,6 +341,14 @@ public Type mysqlTypeToDoris(JdbcFieldSchema fieldSchema) {
return Type.BIGINT;
case "BIGINT":
return ScalarType.createStringType();
+ case "DECIMAL":
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15216:
URL: https://github.com/apache/doris/pull/15216#issuecomment-1359556656
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.88 seconds
load time: 635 seconds
storage size: 17123274847 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221220152152_clickbench_pr_65793.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15216:
URL: https://github.com/apache/doris/pull/15216#issuecomment-1362285057
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15216:
URL: https://github.com/apache/doris/pull/15216#issuecomment-1362285089
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function
Posted by "ZhangGuoqiang666 (via GitHub)" <gi...@apache.org>.
ZhangGuoqiang666 commented on PR #15216:
URL: https://github.com/apache/doris/pull/15216#issuecomment-1423924488
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org