[GitHub] [superset] AAfghahi commented on a change in pull request #15576: feat: Make Google Sheets Dyanmic

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #15576:
URL: https://github.com/apache/superset/pull/15576#discussion_r666392943



##########
File path: superset/db_engine_specs/gsheets.py
##########
@@ -87,6 +105,50 @@ def extra_table_metadata(
 
         return {"metadata": metadata["extra"]}
 
+    @classmethod
+    def build_sqlalchemy_uri(cls) -> str:
+        # All gsheets return just the engine in the format of the uri,
+        # the above are temporary for csi
+        if not cls:

Review comment:
       I added this because you can't have a method without a variable in it. 
   
   Or could I do `def build_sqlalchemy_uri:` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org