You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by metlos <gi...@git.apache.org> on 2016/12/21 22:10:26 UTC
[GitHub] tinkerpop pull request #519: Make ElementHelper.areEqual(Property, Object) h...
GitHub user metlos opened a pull request:
https://github.com/apache/tinkerpop/pull/519
Make ElementHelper.areEqual(Property, Object) handle nulls\u2026
\u2026 so that it can be used correctly in equals() methods of Property impls.
Added test methods for additional equality "scenarios" in ElementHelper.
Note that it is not possible to add tests for equals on `Vertex`, `Edge`, `Property` and `VertexProperty` directly as they are interfaces, not concrete classes. Instead I've added additional test methods for `ElementHelper` to test various case of properties and elements. `ElementHelper.areEqual()` methods are suggested to be used for `equals` of implementations of those interfaces.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/metlos/tinkerpop null-equality-on-props
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #519
----
commit 366a0b473e09ccdb4e49803d1ab804f82faf32e2
Author: Lukas Krejci <lk...@redhat.com>
Date: 2016-12-21T22:02:03Z
Make ElementHelper.areEqual(Property, Object) handle nulls so that it can
be used correctly in equals() methods of Property impls.
Added test methods for additional equality "scenarios" in ElementHelper.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #519: Make ElementHelper.areEqual(Property, Object) h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #519: Make ElementHelper.areEqual(Property, Object) handle n...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/519
Thank you - this has been merged via CTR as it was a pretty straightforward change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---