You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/03 19:24:13 UTC
[GitHub] [geode] DonalEvans opened a new pull request #6000: GEODE-8890: Catch ClassCastException in LocatorDiscovery.java
DonalEvans opened a new pull request #6000:
URL: https://github.com/apache/geode/pull/6000
Authored-by: Donal Evans <do...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [N/A] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] boglesby commented on a change in pull request #6000: GEODE-8890: Catch ClassCastException in LocatorDiscovery.java
Posted by GitBox <gi...@apache.org>.
boglesby commented on a change in pull request #6000:
URL: https://github.com/apache/geode/pull/6000#discussion_r569796598
##########
File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
##########
@@ -133,75 +154,69 @@ public void run() {
}
private WanLocatorDiscoverer getDiscoverer() {
- return this.discoverer;
+ return discoverer;
}
private void exchangeLocalLocators() {
int retryAttempt = 1;
while (!getDiscoverer().isStopped()) {
try {
- RemoteLocatorJoinResponse response =
- (RemoteLocatorJoinResponse) locatorClient.requestToServer(locatorId.getHost(),
- request, WanLocatorDiscoverer.WAN_LOCATOR_CONNECTION_TIMEOUT, true);
+ RemoteLocatorJoinResponse response = (RemoteLocatorJoinResponse) locatorClient
+ .requestToServer(locatorId.getHost(), request, WAN_LOCATOR_CONNECTION_TIMEOUT, true);
if (response != null) {
- LocatorHelper.addExchangedLocators(response.getLocators(), this.locatorListener);
+ addExchangedLocators(response);
logger.info("Locator discovery task exchanged locator information {} with {}: {}.",
Review comment:
While you're changing this method, can you change this this log message a bit?
Currently it looks like:
```
Locator discovery task exchanged locator information 10.212.3.135[10332] with localhost[10331]: {1=[10.212.3.135[10331]], 2=[10.212.3.135[10332]]}.
```
It would make more sense with something like:
```
Locator discovery task for locator 10.212.3.135[10332] exchanged locator information with localhost[10331]: {1=[10.212.3.135[10331]], 2=[10.212.3.135[10332]]}.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #6000: GEODE-8890: Catch ClassCastException in LocatorDiscovery.java
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #6000:
URL: https://github.com/apache/geode/pull/6000#discussion_r569834457
##########
File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
##########
@@ -133,75 +154,69 @@ public void run() {
}
private WanLocatorDiscoverer getDiscoverer() {
- return this.discoverer;
+ return discoverer;
}
private void exchangeLocalLocators() {
int retryAttempt = 1;
while (!getDiscoverer().isStopped()) {
try {
- RemoteLocatorJoinResponse response =
- (RemoteLocatorJoinResponse) locatorClient.requestToServer(locatorId.getHost(),
- request, WanLocatorDiscoverer.WAN_LOCATOR_CONNECTION_TIMEOUT, true);
+ RemoteLocatorJoinResponse response = (RemoteLocatorJoinResponse) locatorClient
+ .requestToServer(locatorId.getHost(), request, WAN_LOCATOR_CONNECTION_TIMEOUT, true);
if (response != null) {
- LocatorHelper.addExchangedLocators(response.getLocators(), this.locatorListener);
+ addExchangedLocators(response);
logger.info("Locator discovery task exchanged locator information {} with {}: {}.",
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #6000: GEODE-8890: Catch ClassCastException in LocatorDiscovery.java
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #6000:
URL: https://github.com/apache/geode/pull/6000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #6000: GEODE-8890: Catch ClassCastException in LocatorDiscovery.java
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #6000:
URL: https://github.com/apache/geode/pull/6000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org