You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Kinga Marton via Review Board <no...@reviews.apache.org> on 2018/08/01 09:59:46 UTC
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 9:59 a.m.)
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
Diff: https://reviews.apache.org/r/68102/diff/2/
Changes: https://reviews.apache.org/r/68102/diff/1-2/
Testing
-------
Tested manually.
Added Junit test.
Thanks,
Kinga Marton
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206741
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Aug. 1, 2018, 1:44 p.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 1:44 p.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/3/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 1:44 p.m.)
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
Diff: https://reviews.apache.org/r/68102/diff/3/
Changes: https://reviews.apache.org/r/68102/diff/2-3/
Testing
-------
Tested manually.
Added Junit test.
Thanks,
Kinga Marton
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206739
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 931-932 (patched)
<https://reviews.apache.org/r/68102/#comment289831>
Can be `final`.
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 946-947 (patched)
<https://reviews.apache.org/r/68102/#comment289832>
Can be `final`.
- András Piros
On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 9:59 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/2/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206740
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 9:59 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/2/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>