[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5198: HADOOP-18546. Followup: ITestReadBufferManager fix

[GitBox <gi...@apache.org>]

pranavsaxena-microsoft commented on code in PR #5198:
URL: https://github.com/apache/hadoop/pull/5198#discussion_r1044187725


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestReadBufferManager.java:
##########
@@ -77,14 +77,7 @@ public void testPurgeBufferManagerForParallelStreams() throws Exception {
         }

Review Comment:
   executorService.shutdown does an orderly shutdown of the task. It does not wait for the tasks to be completed. So, the main thread after executing line 76 will go to line 79, and assertions will happen where the execution of tasks may or may not have got completed.
   
   Requesting you to kindly change to https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#awaitTermination method which will wait for the tasks to be completed. Thanks.
   
   Ref: https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#shutdown()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org