You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/25 14:10:53 UTC

[GitHub] [flink] JackWangCS opened a new pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

JackWangCS opened a new pull request #15373:
URL: https://github.com/apache/flink/pull/15373


   ## What is the purpose of the change
   Currently, the JaasModule and ZooKeeperModule will set some system properties when they are installed. But we don't call the `uninstall()` method to clean up or restore the prior system properties and there will be some dirty properties left on JVM.
   
   This pull request calls SecurityUtils.uninstall() to clean up or restore system properties set by SecurityModules when process exits. 
   
   
   ## Brief change log
     - *Call SecurityUtils.uninstall() to clean up system properties when process exits*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JackWangCS commented on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
JackWangCS commented on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-817274116


   Hi @EronWright, thanks for your comment. I did not realize these properties are ephemeral, I agree that it's not necessary to call the uninstall() method before calling `System.exit()`.
   But if user want to do something customization for submitting jobs using  `CliFrontend` or `FlinkYarnSessionCli` in process, I think we should make the `uninstall()` public and give users an approach to clean or restore the previous system properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806849951


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 74eb04c596ea901aaa3b0d103630b02e09dab391 (Fri May 28 09:02:45 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21699).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JackWangCS edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
JackWangCS edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-817288859


   Another thing is that if a user implements a new `SecurityModule`, the `uninstall()` may be used to do some cleanups such as destroying the screte file. If the `uninstall()` is not called, this also has some unexpected behaviors. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14f4eb622efbea621544e5b0a9f2bc628285da73 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14f4eb622efbea621544e5b0a9f2bc628285da73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470) 
   * 74eb04c596ea901aaa3b0d103630b02e09dab391 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14f4eb622efbea621544e5b0a9f2bc628285da73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16331",
       "triggerID" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74eb04c596ea901aaa3b0d103630b02e09dab391 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16331) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14f4eb622efbea621544e5b0a9f2bc628285da73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JackWangCS edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
JackWangCS edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-817274116


   Hi @EronWright, thanks for your comment. I did not realize these properties are ephemeral, I agree that it's not necessary to call the uninstall() method before calling `System.exit()` for built-in SecurityModules.
   But if user want to do something customization for submitting jobs using  `CliFrontend` or `FlinkYarnSessionCli` in process, I think we should make the `uninstall()` public and give users an approach to clean or restore the previous system properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16331",
       "triggerID" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14f4eb622efbea621544e5b0a9f2bc628285da73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470) 
   * 74eb04c596ea901aaa3b0d103630b02e09dab391 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16331) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806849951


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 14f4eb622efbea621544e5b0a9f2bc628285da73 (Thu Mar 25 14:27:08 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21699).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-806878665


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15470",
       "triggerID" : "14f4eb622efbea621544e5b0a9f2bc628285da73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16331",
       "triggerID" : "74eb04c596ea901aaa3b0d103630b02e09dab391",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74eb04c596ea901aaa3b0d103630b02e09dab391 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16331) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JackWangCS commented on pull request #15373: [FLINK-21699][Runtime] Call SecurityUtils.uninstall() to clean up system properties

Posted by GitBox <gi...@apache.org>.
JackWangCS commented on pull request #15373:
URL: https://github.com/apache/flink/pull/15373#issuecomment-817288859


   Another thing is that if a user implements a new `SecurityModule`, the `uninstall()` may be used to do some cleanups such as destroying the screte file. If the `uninstall()` is not called, this also has some unexpect behaviors. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org