You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/08 08:35:59 UTC

[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on pull request #92: fix: Warning on going back in forms

jawidMuhammadi commented on pull request #92:
URL: https://github.com/apache/fineract-cn-mobile/pull/92#issuecomment-640455723


   As I see we are creating the same dialog with same attributes in each activity, would you make the code a little more modular and less line of code , please? You can create a method named something like`showBackConfirmDialog(Activity activity)` in `Utils` class bypassing the `activity` as a parameter then simply you can call that method in where you need it. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org