You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2015/05/30 09:57:55 UTC
Review Request 34838: DRILL-3155: Part 1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34838/
-----------------------------------------------------------
Review request for drill and Hanifi Gunes.
Repository: drill-git
Description
-------
This patch is a simple refactoring. Moved the classes related to complex vectors in the appropriate package.
Diffs
-----
exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 00a78fd
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java b8d040c
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 323bf43
exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java e602fd7
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java 2b929a4
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 0cbd480
exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java eddefd0
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d62
exec/java-exec/src/main/java/org/apache/drill/exec/vector/ContainerVectorLike.java 95e3365
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedFixedWidthVectorLike.java 450c673
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java 8e097e4
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java 95a7252
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVectorLike.java ac8589e
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/ContainerVectorLike.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java a5553b2
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMutator.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedValueVector.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java PRE-CREATION
Diff: https://reviews.apache.org/r/34838/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 34838: DRILL-3155: Part 1
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34838/#review86320
-----------------------------------------------------------
Ship it!
Ship It!
- Hanifi Gunes
On June 2, 2015, 8:14 p.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34838/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 8:14 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch is a simple refactoring. Moved the classes related to complex vectors in the appropriate package.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 00a78fd
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java b8d040c
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 323bf43
> exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java e602fd7
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java 2b929a4
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 0cbd480
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java eddefd0
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d62
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/ContainerVectorLike.java 95e3365
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedFixedWidthVectorLike.java 450c673
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java 8e097e4
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java 95a7252
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVectorLike.java ac8589e
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/ContainerVectorLike.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java a5553b2
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedValueVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34838/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>
Re: Review Request 34838: DRILL-3155: Part 1
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34838/
-----------------------------------------------------------
(Updated June 2, 2015, 8:14 p.m.)
Review request for drill and Hanifi Gunes.
Changes
-------
Addressed review comments.
Repository: drill-git
Description
-------
This patch is a simple refactoring. Moved the classes related to complex vectors in the appropriate package.
Diffs (updated)
-----
exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 00a78fd
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java b8d040c
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 323bf43
exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java e602fd7
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java 2b929a4
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 0cbd480
exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java eddefd0
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d62
exec/java-exec/src/main/java/org/apache/drill/exec/vector/ContainerVectorLike.java 95e3365
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedFixedWidthVectorLike.java 450c673
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java 8e097e4
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java 95a7252
exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVectorLike.java ac8589e
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/ContainerVectorLike.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java a5553b2
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedValueVector.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java PRE-CREATION
Diff: https://reviews.apache.org/r/34838/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 34838: DRILL-3155: Part 1
Posted by Hanifi Gunes <ha...@gmail.com>.
> On June 1, 2015, 9:01 p.m., Hanifi Gunes wrote:
> >
Few lil stuff.
- Hanifi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34838/#review86070
-----------------------------------------------------------
On May 30, 2015, 7:57 a.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34838/
> -----------------------------------------------------------
>
> (Updated May 30, 2015, 7:57 a.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch is a simple refactoring. Moved the classes related to complex vectors in the appropriate package.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 00a78fd
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java b8d040c
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 323bf43
> exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java e602fd7
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java 2b929a4
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 0cbd480
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java eddefd0
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d62
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/ContainerVectorLike.java 95e3365
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedFixedWidthVectorLike.java 450c673
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java 8e097e4
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java 95a7252
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVectorLike.java ac8589e
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/ContainerVectorLike.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java a5553b2
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMutator.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedValueVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34838/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>
Re: Review Request 34838: DRILL-3155: Part 1
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34838/#review86070
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java
<https://reviews.apache.org/r/34838/#comment137972>
Should drop *public* modifier from interface.
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMutator.java
<https://reviews.apache.org/r/34838/#comment137971>
This class is dead and should be removed along with its uses. We rely on RVV#RepeatedMutator consistently.
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java
<https://reviews.apache.org/r/34838/#comment137973>
Should drop *public* as well.
- Hanifi Gunes
On May 30, 2015, 7:57 a.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34838/
> -----------------------------------------------------------
>
> (Updated May 30, 2015, 7:57 a.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch is a simple refactoring. Moved the classes related to complex vectors in the appropriate package.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 00a78fd
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java b8d040c
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 323bf43
> exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java e602fd7
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java 2b929a4
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 0cbd480
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java eddefd0
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d62
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/ContainerVectorLike.java 95e3365
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedFixedWidthVectorLike.java 450c673
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java 8e097e4
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java 95a7252
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVectorLike.java ac8589e
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/ContainerVectorLike.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java a5553b2
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMutator.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedValueVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34838/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>