You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/11/15 20:09:00 UTC

Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74201/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Ramesh Mani, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-4445
    https://issues.apache.org/jira/browse/ATLAS-4445


Repository: atlas


Description
-------

- updated hive version from 3.1.0 to 3.1.2
- removed packaging jsr311-api in Hive hook


Diffs
-----

  addons/hive-bridge/pom.xml 856e5d95d 
  addons/hive-bridge/src/bin/import-hive.sh ebe6976f0 
  pom.xml ca221fe29 


Diff: https://reviews.apache.org/r/74201/diff/1/


Testing
-------

- verified import-hive.sh in docker setup
- all existing tests pass successfully
- pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1286/


Thanks,

Madhan Neethiraj

Re: Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74201/#review224873
-----------------------------------------------------------


Ship it!




Ship It!

- Sidharth Mishra


On Nov. 15, 2022, 8:08 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74201/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2022, 8:08 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Ramesh Mani, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4445
>     https://issues.apache.org/jira/browse/ATLAS-4445
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated hive version from 3.1.0 to 3.1.2
> - removed packaging jsr311-api in Hive hook
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 856e5d95d 
>   addons/hive-bridge/src/bin/import-hive.sh ebe6976f0 
>   pom.xml ca221fe29 
> 
> 
> Diff: https://reviews.apache.org/r/74201/diff/1/
> 
> 
> Testing
> -------
> 
> - verified import-hive.sh in docker setup
> - all existing tests pass successfully
> - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1288/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74201/#review224874
-----------------------------------------------------------


Ship it!




Ship It!

- Radhika Kundam


On Nov. 15, 2022, 12:08 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74201/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2022, 12:08 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Ramesh Mani, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4445
>     https://issues.apache.org/jira/browse/ATLAS-4445
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated hive version from 3.1.0 to 3.1.2
> - removed packaging jsr311-api in Hive hook
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 856e5d95d 
>   addons/hive-bridge/src/bin/import-hive.sh ebe6976f0 
>   pom.xml ca221fe29 
> 
> 
> Diff: https://reviews.apache.org/r/74201/diff/1/
> 
> 
> Testing
> -------
> 
> - verified import-hive.sh in docker setup
> - all existing tests pass successfully
> - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1288/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

Posted by Madhan Neethiraj <ma...@apache.org>.

> On Nov. 16, 2022, 11:33 p.m., Sidharth Mishra wrote:
> > addons/hive-bridge/src/bin/import-hive.sh
> > Line 97 (original), 97 (patched)
> > <https://reviews.apache.org/r/74201/diff/1/?file=2271812#file2271812line97>
> >
> >     javax.ws.rs-api was added to exclude list to fix https://issues.apache.org/jira/browse/ATLAS-4354. Could you please confirm if this is not needed to be excluded?

Prior to this patch, jsr311-api-1.1 library was packaged in Atlas Hive hook, and javax.ws.rs-api library from Hive lib was excluded from import-hive classpath. This resulted in import-hive to fail with error "java.lang.NoClassDefFoundError: javax/ws/rs/core/Link$Builder".

Addressing this failure requires jsr311-api to be not packaged with Atlas Hive hook, and include javax.ws.rs-api library from Hive lib to import-hive classpath.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74201/#review224868
-----------------------------------------------------------


On Nov. 15, 2022, 8:08 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74201/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2022, 8:08 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Ramesh Mani, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4445
>     https://issues.apache.org/jira/browse/ATLAS-4445
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated hive version from 3.1.0 to 3.1.2
> - removed packaging jsr311-api in Hive hook
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 856e5d95d 
>   addons/hive-bridge/src/bin/import-hive.sh ebe6976f0 
>   pom.xml ca221fe29 
> 
> 
> Diff: https://reviews.apache.org/r/74201/diff/1/
> 
> 
> Testing
> -------
> 
> - verified import-hive.sh in docker setup
> - all existing tests pass successfully
> - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1288/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74201/#review224868
-----------------------------------------------------------




addons/hive-bridge/src/bin/import-hive.sh
Line 97 (original), 97 (patched)
<https://reviews.apache.org/r/74201/#comment313731>

    javax.ws.rs-api was added to exclude list to fix https://issues.apache.org/jira/browse/ATLAS-4354. Could you please confirm if this is not needed to be excluded?


- Sidharth Mishra


On Nov. 15, 2022, 8:08 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74201/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2022, 8:08 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Ramesh Mani, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4445
>     https://issues.apache.org/jira/browse/ATLAS-4445
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated hive version from 3.1.0 to 3.1.2
> - removed packaging jsr311-api in Hive hook
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 856e5d95d 
>   addons/hive-bridge/src/bin/import-hive.sh ebe6976f0 
>   pom.xml ca221fe29 
> 
> 
> Diff: https://reviews.apache.org/r/74201/diff/1/
> 
> 
> Testing
> -------
> 
> - verified import-hive.sh in docker setup
> - all existing tests pass successfully
> - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1288/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74201/#review224878
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 15, 2022, 12:08 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74201/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2022, 12:08 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Ramesh Mani, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4445
>     https://issues.apache.org/jira/browse/ATLAS-4445
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated hive version from 3.1.0 to 3.1.2
> - removed packaging jsr311-api in Hive hook
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 856e5d95d 
>   addons/hive-bridge/src/bin/import-hive.sh ebe6976f0 
>   pom.xml ca221fe29 
> 
> 
> Diff: https://reviews.apache.org/r/74201/diff/1/
> 
> 
> Testing
> -------
> 
> - verified import-hive.sh in docker setup
> - all existing tests pass successfully
> - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1288/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>