[GitHub] [hive] kishendas commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

[GitBox <gi...@apache.org>]

kishendas commented on a change in pull request #1443:
URL: https://github.com/apache/hive/pull/1443#discussion_r480433028



##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
##########
@@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type) throws SQLException {
     Utils.verifySuccess(resp.getStatus());
     return resp;
   }
+
+  private boolean getHiveDefaultNullsLast() {
+    boolean response = ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;

Review comment:
       In Beeline we pick the Hive config and prefix it with hiveconf: and put it in the JDBCParameters.hiveConf. So, I have added the prefix, while looking up for the relevant key in the map. Not sure if there is any other place, where we send the hive conf differently. 

##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
##########
@@ -855,19 +860,19 @@ public boolean nullPlusNonNullIsNull() throws SQLException {
   }
 
   public boolean nullsAreSortedAtEnd() throws SQLException {
-    throw new SQLFeatureNotSupportedException("Method not supported");
+    return false;
   }
 
   public boolean nullsAreSortedAtStart() throws SQLException {
-    throw new SQLFeatureNotSupportedException("Method not supported");
+    return false;
   }
 
   public boolean nullsAreSortedHigh() throws SQLException {

Review comment:
       Added




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org