You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/05/23 22:16:08 UTC
[GitHub] [maven-apache-parent] slawekjaranowski opened a new pull request, #155: [MPOM-289] Use properties to define the versions of plugins
slawekjaranowski opened a new pull request, #155:
URL: https://github.com/apache/maven-apache-parent/pull/155
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] martin-g commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1579291618
FWIW I vote for `apache-rat-plugin.version`
It is much easier to copy/paste the `artifactId` and append/prepend `version`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] michael-o commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1579270507
> > Let's stick to the one we have, it is established and move on.
>
> Which one exactly ?
>
> ```
> <surefire.version>3.1.0</surefire.version> ONE
> <maven.plugin.tools.version>3.9.0</maven.plugin.tools.version> TWO
> <apacheRatPluginVersion>0.15</apacheRatPluginVersion> THREE
> ```
The first two have been superseded and lead to problems, e.g., `release.version`, try and watch it fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] martin-g commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1579255252
> Let's stick to the one we have, it is established and move on.
Which one exactly ?
```
<surefire.version>3.1.0</surefire.version> ONE
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version> TWO
<apacheRatPluginVersion>0.15</apacheRatPluginVersion> THREE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] bmarwell commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1218996175
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
Review Comment:
Please stay consistent in Naming: `surefire.version` != `mavenAssemblyPluginVersion`.
If velocity has problems, let's fix velocity. In freemarker we could just use another syntax, I expect velocity to have the same ability. 3rd party tools (ie non-maven) should not have impact on naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] michael-o commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1579092101
We can have endless debates about a format, at the end you cannot please everyone. Let's stick to the one we have, it is established and move on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] hgschmie commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1574110897
I use `dep.plugin.<plugin-name>.version` properties for a very long time: https://github.com/basepom/basepom/blob/main/poms/foundation/pom.xml#L236-L243
Using a hierarchical naming scheme gives you an opportunity to sort those (e.g. with the sortpom plugin - https://github.com/Ekryd/sortpom) and not have the versions strewn all over the place (the names all align on `dep.plugin` first).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] olamy commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1562054015
I like the idea. Then it will be possible to use interpolation in it pom files to use same version and avoid some download.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] hboutemy commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1215272323
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
- camelCase for such properties is really unusual to many, and *much harder to read* than having a real separator (dot, underscore, dash); Choosing camelCase only for .vm simplification looks IMHO a bad compromise
- whatever the convention for splitting fields, having version as first field for sortability seems a very good idea
- on plugin field: is there an issue with using direct artifactId?
- remember that this PR introduces new properties that many ASF child projects will later use to override: changing the names later will cause much friction, then the choice has to be well thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1213787666
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
I stand by my objection that I think the naming convention could be better... even if you choose not to use dots, using the same name as the plugin artifact and using the word "version" as the prefix rather than the suffix, is better for quickly finding these. It wasn't a problem when there were only a few, but as you're making a bunch of them, keeping them organized becomes more important.
I still think the workaround for the dot in the velocity templates is not a problem... I don't think this should cater to that edge case, because dots are common in Maven and Java, even if velocity doesn't like them. But, even if you do cater to that edge case, there's plenty of ways to improve the naming scheme without using dots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] rmannibucau commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1214014651
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
Agree dots are more expected and velocity usage can be enhanced to support the lookup. In any case camel case looks like inconsistent with maven expressions so maybe not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1204849275
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
The idea is nice, but can we use a naming convention that is more sortable, and groups version-related properties apart from other properties, and uses the artifact name as part of the property, so it's easy to grep for these? Something like `maven-release-plugin -> version.maven-release-plugin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] martin-g commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1218981357
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
> perso I usually use `<artifactId>.version` such `<maven-release-plugin.version>`
> it looks more similar to `object.property`
+1
What about the old properties ?
```
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version>
```
Are you going to change them to be consistent with the new ones ? Any concerns about backward compatibility ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] hboutemy commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1215272323
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
- camelCase for such properties is really unusual to many, and **much harder to read** than having a real separator (dot, underscore, dash); Choosing camelCase only for .vm simplification looks IMHO a bad compromise
- whatever the convention for splitting fields, having version as first field for sortability seems a very good idea
- on plugin identification field: is there an issue with using direct artifactId?
- remember that this PR transparently introduces new properties that many ASF child projects will later use to override: changing the names later will cause much friction, then the choice has to be well thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1205931901
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
@slawekjaranowski The [maven-site-plugin documentation](https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#Filtering) says you can use `$context.get("my.property")`, so that's not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1212739849
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
@ctubbsii I know such workarounds for sitedocs ... but I would like to use properties as simply as possible without additional hacks.
So I will merge as is - if no more objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] hboutemy commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1574807098
> Oh, one other comment on this: I've noticed that overriding versions in the child POMs by overriding the property does not cause versions-maven-plugin to notice newer versions when running: `mvn -U versions:display-plugin-updates`. That's not really an issue for this project... more a deficiency in versions-maven-plugin... but I wanted to mention it here, because if a user used these new properties to override the plugin versions instead of defining a version override in their own `<pluginManagement>` section, they might not notice that the versions-maven-plugin has that limitation.
is there a GH issue opened about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1577581063
> Oh, one other comment on this: I've noticed that overriding versions in the child POMs by overriding the property does not cause versions-maven-plugin to notice newer versions when running: `mvn -U versions:display-plugin-updates`. That's not really an issue for this project... more a deficiency in versions-maven-plugin... but I wanted to mention it here, because if a user used these new properties to override the plugin versions instead of defining a version override in their own `<pluginManagement>` section, they might not notice that the versions-maven-plugin has that limitation.
You can use: `mvn versions:display-property-updates` in such case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1577867484
> You can use: `mvn versions:display-property-updates` in such case
Thanks @slawekjaranowski ! That's good to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1214516616
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
> I respect your opinion, as you look at linked issues such convention is already used in many Maven projects
>
> I also was trying to find what kind of properties are used in other ASF project ... I have found, eg: `<artifactId>.version` `<artifactId>-version` `<artifactId with dot instead of dash>.version`
>
> I didn't found properties with versions word as prefix.
I haven't found many that do this either... but in my experience, it's a much better convention to put version at the front, especially when using plugins like sortpom-maven-plugin to organize the POM and sort the properties. It's very convenient to have all the versions grouped together. Many projects don't know about sortpom-maven-plugin, and don't use it, though, despite it being a superb plugin for POM quality control.
>
> I afraid that there is no convention which can be ok for all, how many projects, so many opinions
Agreed. But my hope is that the reasons I provided are worth serious consideration, and more people will adopt similar conventions on the same grounds, in the absence of arguments against. Specifically: sort-ability and search-ability are the reasons I gave (I think both help with maintainability: smaller diffs, easier to find and update things).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1573924231
Oh, one other comment on this: I've noticed that overriding versions in the child POMs by overriding the property does not cause versions-maven-plugin to notice newer versions when running: `mvn -U versions:display-pluginupdates`. That's not really an issue for this project... more a deficiency in versions-maven-plugin... but I wanted to mention it here, because if a user used these new properties to override the plugin versions instead of defining a version override in their own `<pluginManagement>` section, they might not notice that the versions-maven-plugin has that limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1218669657
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
Ok, I see that more of us is for using dots, and we have also idea for prefix.
So what do you think about:
`version.<artifactId>` - like: `version.maven-release-plugin` - thanks @ctubbsii 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1205928192
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
I'm not sure I understand your use case, but couldn't you use the maven-resources-plugin to filter Maven variables into your velocity templates? Or use your own velocity-compatible variables?
A slight variation that might accommodate that use case would be to use another dash, rather than a dot. The important principle is that "version" comes first, so when the properties are all sorted, the ones that specify versions are all grouped together, and that the part after "version" is the same as the artifact name, so it's easy to grep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] bmarwell commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1215395203
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
+1 for dots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski closed pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski closed pull request #155: [MPOM-289] Use properties to define the versions of plugins
URL: https://github.com/apache/maven-apache-parent/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1220178292
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
I would suggest keeping any existing ones, and only following a consistent convention for new ones, for now. Changing the existing ones to follow the same convention (with a possible attempt for backwards compatibility, through the use of property referencing another property, or through a profile activated using the legacy property, or something else), could be done in a subsequent PR, if somebody wanted to do it. For now, it would be enough to just establish the convention using new properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1205549486
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
I want to reuse those values in many place also in documentation in .vm files ... but we can not use 'dot' for velocity templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1214005448
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
I respect your opinion, as you look at linked issues such convention is already used in many Maven projects
I also was trying to find what kind of properties are used in other ASF project ... I have found, eg:
`<artifactId>.version`
`<artifactId>-version`
`<artifactId with dot instead of dash>.version`
I didn't found properties with versions word as prefix.
I afraid that there is no convention which can be ok for all, how many projects, so many opinions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] hboutemy commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1215272323
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
- camelCase for such properties is really unusual to many, and *much harder to read* than having a real separator (dot, underscore, dash); Choosing camelCase only for .vm simplification looks IMHO a bad compromise
- whatever the convention for splitting fields, having version as first field for sortability seems a very good idea
- on plugin field: is there an issue with using direct artifactId?
- remember that this PR introduces transparently new properties that many ASF child projects will later use to override: changing the names later will cause much friction, then the choice has to be well thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1586091080
suppressed by #158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#issuecomment-1579448506
I created an alternate implementation for my ideas from this discussion at #158, that adopts the `version.$artifactId` naming convention, and addresses the issue with the existing version properties, as well as fixes a few other tiny things (details in the description of that PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-apache-parent] olamy commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #155:
URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1218705783
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+ <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+ <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
perso I usually use `<artifactId>.version` such `<maven-release-plugin.version>`
it looks more similar to `object.property`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org