You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2015/05/05 23:41:18 UTC
[GitHub] activemq-artemis pull request: License stuff
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/228
License stuff
All the example poms needed to be updated so they would use the same location from the license report file (i.e. ratReport.txt). This is necessary so this file can be printed at the end of the Jenkins build so that if the license check fails the developer will know which file caused it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
commit 26a97dc850be3ae92334e44b8092de5193c43aa3
Author: jbertram <jb...@apache.org>
Date: 2015-05-05T19:27:32Z
Revert "disabled RAT plugin by default and updated the docs for releasing explaining how to enable it."
This reverts commit d30ffb79c82e513f62b962aa02417e05bf39a204.
Reverted because the PR build was missing files without the right license.
commit 9dcb2d2faa8026a7c11636a1f72db52d7cb45ec2
Author: jbertram <jb...@apache.org>
Date: 2015-05-05T21:34:41Z
Add license header
commit dc78dd4c50b70272675c5c379ef99063446c0c98
Author: jbertram <jb...@apache.org>
Date: 2015-05-05T21:35:09Z
Re-enable & refactor license check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Spelling fixes
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/228#issuecomment-153434306
I use https://github.com/lyda/misspell-check every now and then on various projects when I'm bored :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Spelling fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/228#issuecomment-153379123
@scop how do you find those? manual inspection or you use any tools? you seem pretty good at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: License stuff
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: License stuff
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/228#discussion_r29716501
--- Diff: examples/core/vertx-connector/pom.xml ---
@@ -32,8 +32,10 @@ under the License.
<name>ActiveMQ Artemis Vert.x Example</name>
<properties>
+ <activemq.basedir>${project.basedir}/../../..</activemq.basedir>
--- End diff --
I'm pretty sure this will be broken under the distribution.. can you try running this after building the distribution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Spelling fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---