You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/15 02:19:19 UTC
[GitHub] [tvm] apivovarov opened a new pull request #8477: Fix _get_yolo_detections
apivovarov opened a new pull request #8477:
URL: https://github.com/apache/tvm/pull/8477
This PR fixes darknet yolo bbox calculation in case network heigh and width are not equal.
I have custom darknet yolo model with shape `[1,1,224,384]`
Without this fix the boxes calculation gets outside of the image boundaries.
tvm_output contains layer_out["output"]. Its shape format is `[_,_,h,w]` (variable `data` in this PR)
But `_get_box` method signature uses `lw, lh` parameters sequence. `_get_box(data, biases, n, location, lw, lh, w, h)`.
the fix maps `lw` to `data[3]` and `lh` to `data[2]`.
The problem was not detected earlier because vanilla yolov2 and yolov3 models network usually have the same Height and Width. For example `[1,3,416,416]` or `[1,3,608,608]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anijain2305 merged pull request #8477: Fix _get_yolo_detections
Posted by GitBox <gi...@apache.org>.
anijain2305 merged pull request #8477:
URL: https://github.com/apache/tvm/pull/8477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anijain2305 commented on pull request #8477: Fix _get_yolo_detections
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on pull request #8477:
URL: https://github.com/apache/tvm/pull/8477#issuecomment-881603716
Thanks @apivovarov @huajsj This is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] apivovarov commented on pull request #8477: Fix _get_yolo_detections
Posted by GitBox <gi...@apache.org>.
apivovarov commented on pull request #8477:
URL: https://github.com/apache/tvm/pull/8477#issuecomment-880343698
@huajsj @siju-samuel @jroesch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] huajsj commented on pull request #8477: Fix _get_yolo_detections
Posted by GitBox <gi...@apache.org>.
huajsj commented on pull request #8477:
URL: https://github.com/apache/tvm/pull/8477#issuecomment-881221104
LGTM, Thanks @apivovarov for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org