[jira] [Work logged] (BEAM-4806) Improve BeamSqlLine unit tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4806?focusedWorklogId=124302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124302 ]

ASF GitHub Bot logged work on BEAM-4806:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/18 03:25
            Start Date: 18/Jul/18 03:25
    Worklog Time Spent: 10m 
      Work Description: akedin commented on a change in pull request #5969: [BEAM-4806] improve unittest for BeamSqlLine
URL: https://github.com/apache/beam/pull/5969#discussion_r203214140
 
 

 ##########
 File path: sdks/java/extensions/sql/jdbc/src/main/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLine.java
 ##########
 @@ -53,7 +58,14 @@ public static void main(String[] args) throws IOException {
     if (nickname == null) {
       wrappedArgs.add("-nn").add(NICKNAME);
     }
-    List<String> wrappedArgList = wrappedArgs.build();
-    SqlLine.main(wrappedArgList.toArray(new String[wrappedArgList.size()]));
+
+    return wrappedArgs.build();
+  }
+
+  public static void testMain(String[] args, PrintStream outputStream) throws IOException {
 
 Review comment:
   This should not be public. At most this should be package-private.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 124302)
    Time Spent: 40m  (was: 0.5h)

> Improve BeamSqlLine unit tests
> ------------------------------
>
>                 Key: BEAM-4806
>                 URL: https://issues.apache.org/jira/browse/BEAM-4806
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)