You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/26 22:10:51 UTC

[GitHub] [samza] cameronlee314 commented on issue #1293: SAMZA-2472: Use runtime-framework-resources-pathing.jar to specify part of the runtime classpath and leverage it in IsolatingClassLoaderFactory

cameronlee314 commented on issue #1293: SAMZA-2472: Use runtime-framework-resources-pathing.jar to specify part of the runtime classpath and leverage it in IsolatingClassLoaderFactory
URL: https://github.com/apache/samza/pull/1293#issuecomment-591670401
 
 
   > @cameronlee314
   > "The pathing JAR is added to the regular classpath in order to keep backwards compatibility"
   > Doesn't look like we're doing this anymore, since base-lib-pathing.jar and the -cp args don't contain HADOOP_CONF_DIR now. Is that intentional?
   > 
   > Otherwise LGTM, thanks for the thorough explanation.
   
   `HADOOP_CONF_DIR` is placed into `runtime-framework-resources-pathing.jar` and `runtime-framework-resources-pathing.jar` is put into the `-cp`. So `HADOOP_CONF_DIR` is still on the classpath through `runtime-framework-resources-pathing.jar`; it is intentionally removed from the direct `-cp` argument, but the functionality should still be the same. Hopefully that addresses your question.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services