Re: [PR] [DRAFT] HTTP/2 rapid reset mitigation [incubator-pekko-http]

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on PR #344:
URL: https://github.com/apache/incubator-pekko-http/pull/344#issuecomment-1855740935

   I've just noticed that this throttle breaks some of the microbenchmarks. I think the throttle might be applied to too many frame types.
   
   Running sbt from the incubator-pekko-http dir and executing
   
   ```
   http-bench-jmh/Jmh/run -i 3 -wi 3 -f1 -t1 org.apache.pekko.http.impl.engine.http2.H2ServerProcessingBenchmark.
   ```
   
   This will fail with the changes in this PR but runs ok without them. The new throttle is set to fail if there are too many frames. This benchmark does not test rapid resets directly - so it appears that the new throttle is affecting too many frame types.
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org