You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by di...@apache.org on 2008/12/03 16:13:50 UTC

svn commit: r722926 - /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXBuilder.java

Author: dims
Date: Wed Dec  3 07:13:49 2008
New Revision: 722926

URL: http://svn.apache.org/viewvc?rev=722926&view=rev
Log:
Fix for WSCOMMONS-406 - Don't expose fields to subclasses

Modified:
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXBuilder.java

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXBuilder.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXBuilder.java?rev=722926&r1=722925&r2=722926&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXBuilder.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXBuilder.java Wed Dec  3 07:13:49 2008
@@ -92,6 +92,14 @@
     protected Map customBuilders = null;
     protected int maxDepthForCustomBuilders = -1;
     
+    /**
+     * Field showing whether the parser is datahandler-aware or not. Client should not directly access this field. 
+     * Instead, they should use {@link #setIsDataHandlerAware(Boolean)} and {@link #isDataHandlerAware()}.
+     * 
+     * @deprecated
+     * @see #isDataHandlerAware()
+     * @see #setIsDataHandlerAware(Boolean)
+     */
     protected Boolean isDataHandlerAware = null; // property of parser, https://issues.apache.org/jira/browse/WSCOMMONS-300
     
     /**
@@ -661,10 +669,9 @@
     /**
      * Check if the underlying parse is aware of data handlers. (example ADB generated code)
      *
-     * @param parser
-     * @return
+     * @return true if the parser is aware of data handlers, otherwise false
      */
-    private boolean isDataHandlerAware() {
+    protected boolean isDataHandlerAware() {
         
         // Is datahandler is immutable for a parser's lifetime.  Thus it should
         // only be checked one time.
@@ -694,6 +701,15 @@
     }
 
     /**
+     * Sets the isDataHandlerAware state of this {@link StAXBuilder}.
+     * 
+     * @param value a boolean value - may be null
+     */
+    protected void setIsDataHandlerAware(Boolean value) {
+        this.isDataHandlerAware = value;
+    }
+    
+    /**
      * Returns the encoding style of the XML data
      * @return the character encoding, defaults to "UTF-8"
      */