You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Harish Agarwal (JIRA)" <ji...@apache.org> on 2010/10/25 23:26:20 UTC
[jira] Created: (SOLR-2195) Externalizing groupValue values
Externalizing groupValue values
-------------------------------
Key: SOLR-2195
URL: https://issues.apache.org/jira/browse/SOLR-2195
Project: Solr
Issue Type: Sub-task
Components: search
Reporter: Harish Agarwal
When grouping on fields like 'SortableIntField', the groupValue returned has not been externalized via indexedToReadable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] Updated: (SOLR-2195) Externalizing groupValue values
Posted by "harish.agarwal" <ha...@gmail.com>.
I would be happy to work on this issue but am not sure where to begin. Any
pointers? I'm guessing I need to use indexedToReadable, but where should it
be used, and how do I grab the fieldType which needs converting?
--
View this message in context: http://lucene.472066.n3.nabble.com/jira-Created-SOLR-2195-Externalizing-groupValue-values-tp1769915p1769968.html
Sent from the Solr - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2195) Externalizing groupValue values
Posted by "Harish Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harish Agarwal updated SOLR-2195:
---------------------------------
Attachment: SOLR-2195.patch
This patch seems to fix the issue - would love to have it looked at and get some feedback. I added ValueFiller's for all of the SortableFieldCache caches as this is where the group search appears to be getting MutableValues from.
> Externalizing groupValue values
> -------------------------------
>
> Key: SOLR-2195
> URL: https://issues.apache.org/jira/browse/SOLR-2195
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Harish Agarwal
> Attachments: SOLR-2195.patch, SOLR-2195.patch
>
>
> When grouping on fields like 'SortableIntField', the groupValue returned has not been externalized via indexedToReadable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2195) Externalizing groupValue values
Posted by "Harish Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harish Agarwal updated SOLR-2195:
---------------------------------
Attachment: SOLR-2195.patch
Attaching a patch which adds a test on SortableIntFields.
> Externalizing groupValue values
> -------------------------------
>
> Key: SOLR-2195
> URL: https://issues.apache.org/jira/browse/SOLR-2195
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Harish Agarwal
> Attachments: SOLR-2195.patch
>
>
> When grouping on fields like 'SortableIntField', the groupValue returned has not been externalized via indexedToReadable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2195) Externalizing groupValue values
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-2195.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Committed. Thanks Harish!
> Externalizing groupValue values
> -------------------------------
>
> Key: SOLR-2195
> URL: https://issues.apache.org/jira/browse/SOLR-2195
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Harish Agarwal
> Fix For: 4.0
>
> Attachments: SOLR-2195.patch, SOLR-2195.patch
>
>
> When grouping on fields like 'SortableIntField', the groupValue returned has not been externalized via indexedToReadable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2195) Externalizing groupValue values
Posted by "Harish Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924802#action_12924802 ]
Harish Agarwal commented on SOLR-2195:
--------------------------------------
Hi Yonik - thanks for the info, I don't see much of a direct link with MutableValue and Trie based fields so I'm not sure what the difference is between Trie based fields and SortableFields - is possible that its a problem with the implementation of toObject in the SortableField's?
> Externalizing groupValue values
> -------------------------------
>
> Key: SOLR-2195
> URL: https://issues.apache.org/jira/browse/SOLR-2195
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Harish Agarwal
> Attachments: SOLR-2195.patch
>
>
> When grouping on fields like 'SortableIntField', the groupValue returned has not been externalized via indexedToReadable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2195) Externalizing groupValue values
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924749#action_12924749 ]
Yonik Seeley commented on SOLR-2195:
------------------------------------
Thanks Harish... it's probably a lack of support in MutableValue (it does work on trie-based numeric fields).
> Externalizing groupValue values
> -------------------------------
>
> Key: SOLR-2195
> URL: https://issues.apache.org/jira/browse/SOLR-2195
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Harish Agarwal
> Attachments: SOLR-2195.patch
>
>
> When grouping on fields like 'SortableIntField', the groupValue returned has not been externalized via indexedToReadable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org