[PR] docs: remove redundant namespace from HTTPRoute, Ingress, and ApisixRoute examples in configure-routes.md [apisix-ingress-controller]

["fengqi-dev (via GitHub)" <gi...@apache.org>]

fengqi-dev opened a new pull request, #2750:
URL: https://github.com/apache/apisix-ingress-controller/pull/2750

   
   
   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   <!-- Select all the options from below that matches the type your PR best -->
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [x] Documentation
   - [ ] Refactor
   - [ ] Chore
   - [ ] CI/CD or Tests
   
   ### What this PR does / why we need it:
   
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   This pull request makes minor updates to the documentation in `docs/en/latest/getting-started/configure-routes.md` by removing the `namespace: ingress-apisix` field from several Kubernetes resource examples. 
   https://github.com/apache/apisix-ingress-controller/blob/878e5015bda978cb2f4231511c835420d8769a2f/examples/httpbin/deployment.yaml#L60-L63
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: remove redundant namespace from HTTPRoute, Ingress, and ApisixRoute examples in configure-routes.md [apisix-ingress-controller]

["fengqi-dev (via GitHub)" <gi...@apache.org>]

fengqi-dev closed pull request #2750: docs: remove redundant namespace from HTTPRoute, Ingress, and ApisixRoute examples in configure-routes.md
URL: https://github.com/apache/apisix-ingress-controller/pull/2750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs: remove redundant namespace from HTTPRoute, Ingress, and ApisixRoute examples in configure-routes.md [apisix-ingress-controller]

["kayx23 (via GitHub)" <gi...@apache.org>]

kayx23 commented on PR #2750:
URL: https://github.com/apache/apisix-ingress-controller/pull/2750#issuecomment-4350955430

   I don't think this change is safe as-is. Removing `metadata.namespace` here changes behavior, not just style.
   
   For the `HTTPRoute` example, the doc defines the `Gateway` in `ingress-apisix` earlier in the same guide. If `httpbin-route.yaml` is applied without an explicit namespace, it will be created in the user's current namespace, so `parentRefs: - name: apisix` may no longer refer to the `Gateway` in `ingress-apisix`. That can break the Gateway API walkthrough.
   
   The same issue applies to the Ingress and `ApisixRoute` examples: without `metadata.namespace`, the examples become dependent on the user's current kubectl context. The guide currently does not set a default namespace and does not use `-n ingress-apisix` when applying the route manifest.
   
   I think we should either:
   1. keep the explicit `namespace: ingress-apisix` in these examples, or
   2. update the whole walkthrough to set/apply a namespace consistently (`kubectl config set-context --current --namespace=ingress-apisix` or `kubectl apply -n ingress-apisix ...`).
   
   Right now this PR makes the docs less explicit and potentially incorrect for the Gateway API case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org