[GitHub] [skywalking] peng-yongsheng commented on issue #2917: Introduce dead line settings from gRPC document.

[GitBox <gi...@apache.org>]

peng-yongsheng commented on issue #2917: Introduce dead line settings from gRPC document.
URL: https://github.com/apache/skywalking/pull/2917#issuecomment-504078355
 
 
   The document you gave have description is 
   - `By default this deadline is a very large number, dependent on the language implementation.`
   - `This sets the deadline to 100ms from when the client RPC is set to when the response is picked up by the client.`
   
   But from the error log you gave is that `deadline exceeded after 969455382ns`.
   
    **Important thing: 969455382ns == 900ms == 0.9s**
   We don't set the deadline before this PR, and our agent and OAP server are written with Java language, so the deadline should the default value of 100ms.
   
   Question: 
   - I'm very curious about why the deadline exceeded is 900ms instead of 100ms?
   - Why you set the deadline to 10s? The document said: `In general, when you don’t set a deadline, resources will be held for all in-flight requests, and all requests can potentially reach the maximum timeout. This puts the service at risk of running out of resources, like memory, which would increase the latency of the service, or could crash the entire process in the worst case.` I think the 10s deadline is too large because the agent sends the segments to the server-side every 30s. No more time for the next round. I suggest make it smaller is best. **5s**?
   
   @wu-sheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services