[GitHub] [helix] jiajunwang commented on a change in pull request #1894: Fix log format in instanceValidationUtil

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1894:
URL: https://github.com/apache/helix/pull/1894#discussion_r734695541



##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -169,9 +169,9 @@ public static boolean hasValidConfig(HelixDataAccessor dataAccessor, String clus
       return false;
     }
     if (!clusterConfig.isPersistIntermediateAssignment()) {
-      _logger.error(
+      _logger.error(String.format(

Review comment:
       Use {} in the log string, please. FYI, https://garygregory.wordpress.com/2015/09/16/a-gentle-introduction-to-the-log4j-api-and-lambda-basics/
   
   Good catch, BTW!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org