You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "KnightChess (via GitHub)" <gi...@apache.org> on 2023/12/26 12:06:11 UTC
[PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
KnightChess opened a new pull request, #10412:
URL: https://github.com/apache/hudi/pull/10412
config:
occ open
use FileSystemBasedLock
mdt is open in write defualt
there has three job, jobA, jobB, jobC, these three jobs are running at the same time.
jobA get lock success, jobB has been trying to get lock, jobC also try to get lock.
jobB failed because can not get lock, but it delete lock file when close write client, now, jobC will get lock, it cause concurrent problem.
In our case, jobC will rollback jobA mdt commit which has been succeed commited. So, the data table timeline has the repleaseCommit instance, but mdt without this update, it cause partition path be deleted and can not reserve the latest file split in our case
### Change Logs
- will check lock create_time in memory before delete lock file
- only lock owner or lock is expired can delete lock
### Impact
- the lock file may always exist. If the process exits normally and the expiration time is not set up
### Risk level (write none, low medium or high below)
medium
### Documentation Update
None
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1869934300
We are planning to make the MDT non-blocking, hope that helps in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1870810416
We have re-designed the lock acquisition since 1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1870229713
> We are planning to make the MDT non-blocking, hope that helps in this scenario.
you mean rfc-66? Let me study it.
but I think this will cause other unpredictable exception not only mdt meta, because multiple job get the lock in the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1869847042
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b7e66703eb4da5ac80a77ca156ad1c34ef60ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21702",
"triggerID" : "83b7e66703eb4da5ac80a77ca156ad1c34ef60ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b7e66703eb4da5ac80a77ca156ad1c34ef60ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21702)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess closed pull request #10412: [HUDI-7529] fix multiple tasks get the lock at the same time when use…
URL: https://github.com/apache/hudi/pull/10412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1979984556
close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1887201534
@danny0405 hi, is there any other modification suggestions for this question? Or this pr no need land?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1869939108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b7e66703eb4da5ac80a77ca156ad1c34ef60ad",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21702",
"triggerID" : "83b7e66703eb4da5ac80a77ca156ad1c34ef60ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b7e66703eb4da5ac80a77ca156ad1c34ef60ad Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21702)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10412:
URL: https://github.com/apache/hudi/pull/10412#issuecomment-1869844515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b7e66703eb4da5ac80a77ca156ad1c34ef60ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83b7e66703eb4da5ac80a77ca156ad1c34ef60ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b7e66703eb4da5ac80a77ca156ad1c34ef60ad UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7529] fix multiple tasks get the lock at the same time when use… [hudi]
Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess closed pull request #10412: [HUDI-7529] fix multiple tasks get the lock at the same time when use…
URL: https://github.com/apache/hudi/pull/10412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org