[GitHub] [hive] kgyrtkirk commented on a change in pull request #3067: HIVE-25997: Fix release source packaging

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #3067:
URL: https://github.com/apache/hive/pull/3067#discussion_r817570663



##########
File path: packaging/src/main/assembly/src.xml
##########
@@ -100,12 +100,26 @@
         <include>storage-api/**/*</include>
         <include>standalone-metastore/metastore-common/**/*</include>
         <include>standalone-metastore/metastore-server/**/*</include>
+        <include>standalone-metastore/metastore-tools/**/*</include>
+        <include>standalone-metastore/src/assembly/src.xml</include>
+        <include>standalone-metastore/pom.xml</include>

Review comment:
       these modules are not fully separated - meaning they are connected to the root pom.xml;
   if we really want to separate them - we can put them into a new project...
   
   but honestly I think these things were released separetly because there were no regular Hive releases....




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org