You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by nikhilbhide <gi...@git.apache.org> on 2017/09/11 16:33:36 UTC
[GitHub] zookeeper pull request #371: ZOOKEEPER-2814: Ignore space after comma in con...
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/371
ZOOKEEPER-2814: Ignore space after comma in connection string
Ported ZOOKEEPER-2814 from master to branch 3.4.
Added files
src/java/main/org/apache/zookeeper/common/StringUtils.java
src/java/test/org/apache/zookeeper/test/StringUtilTest.java
Modified Files:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #371
----
commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
Author: Nikhil Bhide <ni...@gmail.com>
Date: 2017-09-11T13:14:29Z
ZOOKEEPER-2814: Ignore space after comma in connection string
Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space after comma in connection string
Port ZOOKEEPER-2814 from master
commit 3f210394e989507282d1e42fb9f3e35512d314e8
Author: Nikhil Bhide <ni...@gmail.com>
Date: 2017-09-11T13:19:44Z
Zookeeper 2814: ignore space after comma in connection string
Port Zookeeper 2814 from master to branch - 3.4
Created StringUtils.java
commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
Author: Nikhil Bhide <ni...@gmail.com>
Date: 2017-09-11T13:22:26Z
ZOOKEEPER-2814: Ignore space after comma in connection string
Port ZOOKEEPER-2814 from master to branch-3.4
Added code to test split logic implemented in StringUtils.java
commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
Author: Nikhil Bhide <ni...@gmail.com>
Date: 2017-09-11T13:26:08Z
ZOOKEEPER-2814: Ignore space after comma in connection string
Port ZOOKEEPER-2814 from master to branch-3.4
Added test to verify the logic added to remove the spaces provided in connection string
commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a
Author: Nikhil Bhide <ni...@gmail.com>
Date: 2017-09-11T15:15:34Z
ZOOKEEPER-2814: Ignore space after comma in connection string
Ported ZOOKEEPER-2814 from master to 3.4
commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2
Author: Nikhil Bhide <ni...@gmail.com>
Date: 2017-09-11T15:16:58Z
ZOOKEEPER-2814: Ignore space after comma in connection string
----
---
[GitHub] zookeeper issue #371: ZOOKEEPER-2814: Ignore space after comma in connection...
Posted by mfenes <gi...@git.apache.org>.
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/371
Regex implementation would be shorter to ignore the spaces and empty strings as
```
connectString.replaceAll("\\s", "").replaceAll(",+", ",").split(",")
```
does the same thing as the new StringUtils.split(String value, String separator) implementation in this PR.
---
[GitHub] zookeeper issue #371: ZOOKEEPER-2814: Ignore space after comma in connection...
Posted by dolphy17 <gi...@git.apache.org>.
Github user dolphy17 commented on the issue:
https://github.com/apache/zookeeper/pull/371
I prefer the regex solution too as @mfenes did.
---